RuntimeError: version info string is not terminated by zero

[Napo2k]

In the version info parser (this line), it seems that it is not possible for a file to have the last number on the version be anything other than zero, and I was wondering why is that a problem?

[avakar]

That line is a check that UTF-16-encoded strings in the version info blob are terminated by the U+0000 character. It's a check on the validity of serialization, not on the validity of contents. Versions can end in "0" just fine.

[Napo2k]

I keep getting that error and I have no idea how to fix it😅 I am using pe_tools as part of our binary info stamping. The version to be stamped has four fields ('XX.YY.ZZ.PP')

[avakar]

I can have a look if you link the binary and provide the command line you're using.

[Napo2k]

Thank you for the response. Let me ask if that is possible.

[Napo2k]

In the meantime, I have added a print in my local copy of pe_tools, and this is what I can see

b'3\x002\x00.\x000\x00.\x004\x003\x009\x00.\x008\x002\x005\x001\x00'
32.0.439.8251
(...)
│ W:\gitlab\build_tool\.env\lib\site-packages\pe_tools\version_info.py:238 in _parse_one           │
│                                                                                                  │
│   235 │   │   │   if bytes(value[-2:]) != b'\0\0':                                               │
│   236 │   │   │   │   print(bytes(value))                                                        │
│   237 │   │   │   │   print(bytes(value).decode('utf-16le'))                                     │
│ ❱ 238 │   │   │   │   raise RuntimeError('version info string is not terminated by zero')        │
│   239 │   │   │   value = bytes(value[:-2]).decode('utf-16le')                                   │
│   240 │                                                                                          │
│   241 │   children = []                                                                          │
│                                                                                                  │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │      blob = rope()                                                                           │ │
│ │       hdr = _NODE_HEADER(wLength=60, wValueLength=13, wType=1)                               │ │
│ │       key = 'FileVersion'                                                                    │ │
│ │  key_size = 24                                                                               │ │
│ │      next = rope(<_io.BufferedReader                                                         │ │
│ │             name='W:\\zzbuilds\\output\\foo.exe'>[35188860:35189652])             │ │
│ │     value = rope(<_io.BufferedReader                                                         │ │
│ │             name='W:\\zzbuilds\\output\\foo.exe'>[35188832:35188858])             │ │
│ │ value_len = 26                                                                               │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RuntimeError: version info string is not terminated by zero

[Napo2k]

Any idea?