Cey feedback

Author: JonathanOppenheimer

params/extras/precompile_upgrade_test.go

@@ -288,15 +288,15 @@ func (tt *upgradeCompatibilityTest) run(t *testing.T, chainConfig ChainConfig) {
 		// if this is not the final upgradeBytes, continue applying
 		// the next upgradeBytes. (only check the result on the last apply)
 		if i != len(tt.configs)-1 {
-			require.NoErrorf(t, err, "expecting checkConfigCompatible call %d to return nil", i+1)
+			require.NoError(t, err, "expecting checkConfigCompatible call %d to return nil", i+1)
 			chainConfig = newCfg
 			continue
 		}
 
 		if tt.expectedErrorString != "" {
 			require.ErrorContains(t, err, tt.expectedErrorString)
 		} else {
-			require.Nil(t, err)
+			require.NoError(t, err, "expecting checkConfigCompatible call %d to return nil", i+1)
 		}
 	}
 }

sync/client/client_test.go

@@ -665,8 +665,8 @@ func TestGetLeafs(t *testing.T) {
 				return
 			}
 
-			leafsResponse, ok := response.(message.LeafsResponse)
-			require.True(t, ok, "expected leafs response")
+			leafsResponse := response.(message.LeafsResponse)
+			require.IsType(t, message.LeafsResponse{}, leafsResponse, "parseLeafsResponse returned incorrect type %T", leafsResponse)
 			test.requireResponse(t, leafsResponse)
 		})
 	}