sync: coreth PR #1372: style: use t.Context() (#1861)

Author: JonathanOppenheimer

.avalanche-golangci.yml

@@ -82,6 +82,7 @@ linters:
     - unparam
     - unused
     - usestdlibvars
+    - usetesting
     - whitespace
   settings:
     depguard:
@@ -228,6 +229,14 @@ linters:
       # Mark all local variables as used.
       # default: true
       local-variables-are-used: false
+    usetesting:
+      os-create-temp:     true # Disallow `os.CreateTemp("", ...)`
+      os-mkdir-temp:      true # Disallow `os.MkdirTemp()`
+      os-setenv:          true # Disallow `os.Setenv()`
+      os-temp-dir:        true # Disallow `os.TempDir()`
+      os-chdir:           true # Disallow `os.Chdir()`
+      context-background: true # Disallow `context.Background()`
+      context-todo:       true # Disallow `context.TODO()` 
   exclusions:
     generated: lax
     presets:

eth/gasprice/fee_info_provider_test.go

@@ -4,7 +4,6 @@
 package gasprice
 
 import (
-	"context"
 	"math/big"
 	"sync"
 	"testing"
@@ -52,7 +51,7 @@ func TestFeeInfoProviderCacheSize(t *testing.T) {
 	// to test eviction behavior.
 	for i := 0; i < size+feeCacheExtraSlots+overflow; i++ {
 		header := &types.Header{Number: big.NewInt(int64(i))}
-		_, err := f.addHeader(context.Background(), header, []*types.Transaction{})
+		_, err := f.addHeader(t.Context(), header, []*types.Transaction{})
 		require.NoError(t, err)
 	}
 

eth/tracers/api_extra_test.go

@@ -4,7 +4,6 @@
 package tracers
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"math/big"
@@ -132,7 +131,7 @@ func testTraceBlockPrecompileActivation(t *testing.T, scheme string) {
 		},
 	}
 	for i, tc := range testSuite {
-		result, err := api.TraceBlockByNumber(context.Background(), tc.blockNumber, tc.config)
+		result, err := api.TraceBlockByNumber(t.Context(), tc.blockNumber, tc.config)
 		if tc.expectErr != nil {
 			if err == nil {
 				t.Errorf("test %d, want error %v", i, tc.expectErr)
@@ -210,7 +209,7 @@ func testTraceTransactionPrecompileActivation(t *testing.T, scheme string) {
 	api := NewAPI(backend)
 	for i, target := range blockNoTxMap {
 		t.Run(fmt.Sprintf("blockNumber %d", i), func(t *testing.T) {
-			result, err := api.TraceTransaction(context.Background(), target, nil)
+			result, err := api.TraceTransaction(t.Context(), target, nil)
 			require := require.New(t)
 			require.NoError(err)
 			var have *logger.ExecutionResult
@@ -300,8 +299,8 @@ func testTraceChainPrecompileActivation(t *testing.T, scheme string) {
 		ref.Store(0)
 		rel.Store(0)
 
-		from, _ := api.blockByNumber(context.Background(), rpc.BlockNumber(c.start))
-		to, _ := api.blockByNumber(context.Background(), rpc.BlockNumber(c.end))
+		from, _ := api.blockByNumber(t.Context(), rpc.BlockNumber(c.start))
+		to, _ := api.blockByNumber(t.Context(), rpc.BlockNumber(c.end))
 		resCh := api.traceChain(from, to, c.config, nil)
 
 		next := c.start + 1
@@ -443,7 +442,7 @@ func testTraceCallWithOverridesStateUpgrade(t *testing.T, scheme string) {
 		},
 	}
 	for i, testspec := range testSuite {
-		result, err := api.TraceCall(context.Background(), testspec.call, rpc.BlockNumberOrHash{BlockNumber: &testspec.blockNumber}, testspec.config)
+		result, err := api.TraceCall(t.Context(), testspec.call, rpc.BlockNumberOrHash{BlockNumber: &testspec.blockNumber}, testspec.config)
 		if testspec.expectErr != nil {
 			require.ErrorIs(t, err, testspec.expectErr, "test %d", i)
 			continue

internal/ethapi/api_extra_test.go

@@ -4,7 +4,6 @@
 package ethapi
 
 import (
-	"context"
 	"errors"
 	"math/big"
 	"os"
@@ -47,7 +46,7 @@ func TestBlockchainAPI_GetChainConfig(t *testing.T) {
 
 	api := NewBlockChainAPI(backend)
 
-	gotConfig := api.GetChainConfig(context.Background())
+	gotConfig := api.GetChainConfig(t.Context())
 	assert.Equal(t, params.ToWithUpgradesJSON(wantConfig), gotConfig)
 }
 
@@ -77,7 +76,7 @@ func TestBlockchainAPI_CallDetailed(t *testing.T) {
 	}))
 
 	result, err := api.CallDetailed(
-		context.Background(),
+		t.Context(),
 		TransactionArgs{
 			From:  &accounts[0].addr,
 			To:    &accounts[1].addr,