From 9bda12bd1b796036bd20f268a6611b24306f9cac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mete=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 1 Sep 2026 11:05:43 +0300 Subject: [PATCH 1/4] docs(ansible): align agnocast README with the role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The README described the role at v2.1.2. The tasks changed after that. - Set the version to 2.3.5. - Point the upstream link to autowarefoundation/agnocast. - List the three overridable defaults under Inputs. - Add the ansible-playbook command with the agnocast tag. - Install the kernel headers before the kmod, as the role does. - Check the dkms state with `dkms status agnocast/ | grep -q installed`. The old check had no `$` in `{agnocast_version}` and never matched. - Load the module at boot via /etc/modules-load.d/agnocast.conf. Signed-off-by: Mete Fatih Cırıt --- ansible/roles/agnocast/README.md | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/ansible/roles/agnocast/README.md b/ansible/roles/agnocast/README.md index e1441aeeb59..bdd107e693a 100644 --- a/ansible/roles/agnocast/README.md +++ b/ansible/roles/agnocast/README.md @@ -1,15 +1,31 @@ # agnocast -This role installs [Agnocast](https://github.com/tier4/agnocast), true zero-copy communication middleware for all ROS 2 message types. +This role installs [Agnocast](https://github.com/autowarefoundation/agnocast), true zero-copy communication middleware for all ROS 2 message types. ## Inputs -None. +| Name | Required | Description | +| ------------------------- | -------- | ------------------------------------------------------------------------------------------------ | +| agnocast_version | false | The version of Agnocast. | +| agnocast_heaphook_package | false | The apt package of the heaphook library. The default is `agnocast-heaphook-v`. | +| agnocast_kmod_package | false | The apt package of the kernel module. The default is `agnocast-kmod-v`. | + +## Installation with Ansible + +Install Ansible first. The steps are in the [ansible installation guide](../../README.md#ansible-installation). + +```bash +cd ~/autoware # The root directory of the cloned repository +ansible-galaxy collection install -f -r "ansible-galaxy-requirements.yaml" +ansible-playbook autoware.dev_env.install_dev_env --tags agnocast --ask-become-pass +``` + +If you need a different version, add `-e agnocast_version=` to the last command. ## Manual Installation ```bash -agnocast_version="2.1.2" +agnocast_version="2.3.5" agnocast_heaphook_package="agnocast-heaphook-v${agnocast_version}" agnocast_kmod_package="agnocast-kmod-v${agnocast_version}" @@ -17,11 +33,14 @@ sudo add-apt-repository -y ppa:t4-system-software/agnocast sudo apt update sudo apt install -y "${agnocast_heaphook_package}" -if dkms status | grep agnocast | grep -q "{agnocast_version}"; then - echo "agnocast-kmod-v${agnocast_version} is already registered in dkms. Skipping purge and install." +sudo apt install -y "linux-headers-$(uname -r)" + +if dkms status "agnocast/${agnocast_version}" | grep -q installed; then + echo "agnocast-kmod-v${agnocast_version} is already installed in dkms. Skipping purge and install." else sudo apt purge -y "${agnocast_kmod_package}" sudo apt install -y "${agnocast_kmod_package}" fi +echo agnocast | sudo tee /etc/modules-load.d/agnocast.conf ``` From bc00643b398fb36da707c9dcd7e7d9a99c43e092 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mete=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 1 Sep 2026 15:11:20 +0300 Subject: [PATCH 2/4] chore(codeowners): add Koichi98 as owner of the agnocast role (#7294) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CODEOWNERS is last-match-wins with no owner merging, so the new line repeats the ansible/** owners and appends @Koichi98. Signed-off-by: Mete Fatih Cırıt --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ffea06d2b26..1ccae1a10a2 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,4 +3,5 @@ .devcontainer/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org .github/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org ansible/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org +ansible/roles/agnocast/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org @Koichi98 docker/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org From c56fed73cbba74d69eb7be8cd8218a265f7d7f12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mete=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 1 Sep 2026 15:44:38 +0300 Subject: [PATCH 3/4] docs(ansible): drop the manual snippet from the agnocast README MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The snippet was a second copy of the role in shell, and it drifted: an old version, add-apt-repository, and a dkms check that never matched. The Ansible command is now the only installation step, as in the acados and qt5ct_setup READMEs. Signed-off-by: Mete Fatih Cırıt --- ansible/roles/agnocast/README.md | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/ansible/roles/agnocast/README.md b/ansible/roles/agnocast/README.md index bdd107e693a..6c9bb44bed5 100644 --- a/ansible/roles/agnocast/README.md +++ b/ansible/roles/agnocast/README.md @@ -10,7 +10,7 @@ This role installs [Agnocast](https://github.com/autowarefoundation/agnocast), t | agnocast_heaphook_package | false | The apt package of the heaphook library. The default is `agnocast-heaphook-v`. | | agnocast_kmod_package | false | The apt package of the kernel module. The default is `agnocast-kmod-v`. | -## Installation with Ansible +## Installation Install Ansible first. The steps are in the [ansible installation guide](../../README.md#ansible-installation). @@ -21,26 +21,3 @@ ansible-playbook autoware.dev_env.install_dev_env --tags agnocast --ask-become-p ``` If you need a different version, add `-e agnocast_version=` to the last command. - -## Manual Installation - -```bash -agnocast_version="2.3.5" -agnocast_heaphook_package="agnocast-heaphook-v${agnocast_version}" -agnocast_kmod_package="agnocast-kmod-v${agnocast_version}" - -sudo add-apt-repository -y ppa:t4-system-software/agnocast -sudo apt update -sudo apt install -y "${agnocast_heaphook_package}" - -sudo apt install -y "linux-headers-$(uname -r)" - -if dkms status "agnocast/${agnocast_version}" | grep -q installed; then - echo "agnocast-kmod-v${agnocast_version} is already installed in dkms. Skipping purge and install." -else - sudo apt purge -y "${agnocast_kmod_package}" - sudo apt install -y "${agnocast_kmod_package}" -fi - -echo agnocast | sudo tee /etc/modules-load.d/agnocast.conf -``` From 758d5294454aeb001bea0085ce2c738a09c93c49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mete=20Fatih=20C=C4=B1r=C4=B1t?= Date: Tue, 1 Sep 2026 16:41:01 +0300 Subject: [PATCH 4/4] chore(codeowners): use the email of Koichi98 for the agnocast role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The other owners in the file are email addresses. The GitHub handle was the only exception. Signed-off-by: Mete Fatih Cırıt --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1ccae1a10a2..911bf45d2b6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,5 +3,5 @@ .devcontainer/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org .github/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org ansible/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org -ansible/roles/agnocast/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org @Koichi98 +ansible/roles/agnocast/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org koichi.imai.2@tier4.jp docker/** oguzkaganozt@gmail.com yutaka.kondo@tier4.jp isamu.takagi@tier4.jp ryohsuke.mitsudome@tier4.jp mfc@autoware.org