Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return parameter in the description of compute_loss in counterfactual.py #2

Open
felixmeyjr opened this issue Dec 2, 2021 · 3 comments

Comments

@felixmeyjr
Copy link

In the compute_loss(...) the docstring states:

Returns:
difference (torch.tensor): The summed square error between output and desired_output.

That is the parameter of compute_output_difference.

@maxidl
Copy link
Contributor

maxidl commented Dec 2, 2021

Thank you for reporting, fixed it just now.

@felixmeyjr
Copy link
Author

How can we pull the changes in iML-ws21-ex08 to iML-ws21-ex08-TEAMNAME anyway? Upstream branch is origin/master of iML-ws21-ex08-TEAMNAME.

@maxidl
Copy link
Contributor

maxidl commented Dec 2, 2021

While it sure doesn't feel like an optimal solution, you can try the solution from here:

git remote add template https://github.com/automl-classroom/iml-ws21-ex08
git fetch --all
git merge --allow-unrelated-histories template/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants