From 246be66f9fd31cadfa1b7ffe1531168b9a57da59 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Fri, 31 Oct 2025 13:51:22 -0400 Subject: [PATCH] chore: disable revision heartbeat in PG revision tests They may be interfering with the expected revisions and therefore causing flakiness --- internal/datastore/postgres/postgres.go | 2 +- internal/datastore/postgres/postgres_shared_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/datastore/postgres/postgres.go b/internal/datastore/postgres/postgres.go index 1e1e8799d..662808a4f 100644 --- a/internal/datastore/postgres/postgres.go +++ b/internal/datastore/postgres/postgres.go @@ -364,7 +364,7 @@ func newPostgresDatastore( datastore.SetOptimizedRevisionFunc(datastore.optimizedRevisionFunc) - // Start a goroutine for garbage collection. + // Start a goroutine for garbage collection and the revision heartbeat. if isPrimary { datastore.workerGroup, datastore.workerCtx = errgroup.WithContext(datastore.workerCtx) if config.revisionHeartbeatEnabled { diff --git a/internal/datastore/postgres/postgres_shared_test.go b/internal/datastore/postgres/postgres_shared_test.go index 1b6469941..32a5f6d35 100644 --- a/internal/datastore/postgres/postgres_shared_test.go +++ b/internal/datastore/postgres/postgres_shared_test.go @@ -895,6 +895,7 @@ func QuantizedRevisionTest(t *testing.T, b testdatastore.RunningEngineForTest) { GCWindow(24*time.Hour), WatchBufferLength(1), FollowerReadDelay(tc.followerReadDelay), + WithRevisionHeartbeat(false), ) require.NoError(err) @@ -972,6 +973,7 @@ func OverlappingRevisionTest(t *testing.T, b testdatastore.RunningEngineForTest) GCWindow(24*time.Hour), WatchBufferLength(1), FollowerReadDelay(tc.followerReadDelay), + WithRevisionHeartbeat(false), ) require.NoError(err)