Skip to content

Conversation

@kushalshit27
Copy link
Contributor

🔧 Changes

  • Schema Validation Fix: Added read_only_background property to the theme colors schema.

📚 References

🔬 Testing

Manual testing steps:

  1. Export a tenant configuration: a0deploy export -c ./config.json -f yaml -o ./output
  2. If the tenant has themes with read_only_background colors defined, verify the exported YAML includes them
  3. Re-import the exported configuration without modifications: a0deploy import -c ./config.json -i ./output/tenant.yaml
  4. Verify the import succeeds without schema validation errors

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

- src/tools/auth0/handlers/themes.ts: add read_only_background with pattern and type validation
@kushalshit27 kushalshit27 changed the title Fix: add read_only_background property to schema fix: add read_only_background property to schema Oct 23, 2025
@kushalshit27 kushalshit27 changed the title fix: add read_only_background property to schema fix: add read_only_background property to schema for themes Oct 23, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (4ce981f) to head (68b38c9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   80.12%   80.12%           
=======================================
  Files         134      134           
  Lines        5107     5107           
  Branches     1016     1016           
=======================================
  Hits         4092     4092           
  Misses        581      581           
  Partials      434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 marked this pull request as ready for review October 29, 2025 06:39
@kushalshit27 kushalshit27 requested a review from a team as a code owner October 29, 2025 06:39
@kushalshit27 kushalshit27 merged commit 8342a27 into master Oct 29, 2025
7 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-1285-fix-schema-validation-rejects-read-only-background-property branch October 29, 2025 09:49
@kushalshit27 kushalshit27 mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema validation rejects read_only_background property that was exported by a0deploy itself

4 participants