Skip to content

Conversation

@ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Oct 16, 2025

🔧 Changes

Adds the skip_non_verifiable_callback_uri_confirmation_prompt property to both Tenant Settings and Client Applications resources. This boolean property allows tenants and clients to skip the confirmation prompt when using non-verifiable callback URIs, supporting Auth0's enhanced security workflow configuration.

Tenant Settings Configuration:

tenant:
  skip_non_verifiable_callback_uri_confirmation_prompt: true
  flags:
    enable_public_signup_user_exists_error: false

Client Applications Configuration:

clients:
  - name: "My SPA Application"
    app_type: "spa"
    callbacks: 
      - "http://localhost:3000/callback"
    skip_non_verifiable_callback_uri_confirmation_prompt: true
    grant_types:
      - "authorization_code"

📚 References

API Endpoints Supported:

  • ✅ GET/PATCH /api/v2/tenants/settings - manages tenant-level setting
  • ✅ GET/POST/PATCH /api/v2/clients and /api/v2/clients/{id} - manages client-level setting
  • ✅ Accepts true, false, and null values as per Auth0 API specification

🔬 Testing

  • Added unit tests for tenant flag filtering that includes the new property
  • Manually tested export/import workflows with both YAML and directory formats
  • Verified keyword replacement functionality works correctly with the new property

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (06d6198) to head (a49c2d0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   80.12%   80.12%           
=======================================
  Files         134      134           
  Lines        5107     5107           
  Branches     1016     1016           
=======================================
  Hits         4092     4092           
  Misses        581      581           
  Partials      434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ramya18101 ramya18101 marked this pull request as ready for review October 16, 2025 11:50
@ramya18101 ramya18101 requested review from a team as code owners October 16, 2025 11:50
@kushalshit27
Copy link
Contributor

@claude

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Claude finished @kushalshit27's task —— View job


Overall Assessment

❌ This pull request has a few issues that should be addressed before merging. The implementation is functionally sound with proper test coverage, but contains debug console.log statements that should be removed and has minor type definition inconsistencies that should be corrected for production quality.


View Job Run | Branch: DXCDT-1081-Support-Security-Custom-URI-Schemes

@kushalshit27 kushalshit27 marked this pull request as draft October 21, 2025 05:07
@kushalshit27
Copy link
Contributor

please, check the pipelines

Please keep the PR title as the the standard:

  • feat: add support for new resource type
  • fix: resolve table formatting issue
  • docs: update handler implementation guide
  • test: add coverage for keyword replacement
  • `refactor: simplify change calculation logic

@ramya18101 ramya18101 marked this pull request as ready for review October 29, 2025 08:57
@ramya18101 ramya18101 changed the title add support for Security-Custom-URI-Schemes in client and tenant feat: add support for Security-Custom-URI-Schemes in client and tenant Oct 29, 2025
Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the node SDK that supports the keys

@ramya18101 ramya18101 merged commit dfbbc04 into master Oct 31, 2025
7 checks passed
@ramya18101 ramya18101 deleted the DXCDT-1081-Support-Security-Custom-URI-Schemes branch October 31, 2025 01:39
@kushalshit27 kushalshit27 mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants