-
Notifications
You must be signed in to change notification settings - Fork 172
fix: execution order for logStreams
#1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: execution order for logStreams
#1175
Conversation
- src/tools/auth0/handlers/logStreams.ts: import 'order' decorator and apply it to processChanges method - src/tools/auth0/index.ts: improve sortByOrder function to handle NaN cases and ensure proper sorting of handlers by order
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 80.23% 80.17% -0.07%
==========================================
Files 134 134
Lines 5096 5100 +4
Branches 1013 1014 +1
==========================================
Hits 4089 4089
- Misses 578 579 +1
- Partials 429 432 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
clientGrants processes before logStreams
clientGrants processes before logStreamslogStreams
|
Claude finished @kushalshit27's task —— View job Review Progress
Overall Assessment❌ The PR has several issues that should be addressed before merging. While the order decorator validation is solid, the execution order choice creates ambiguity, the sorting function has a minor inefficiency, lacks defensive NaN handling, and there's no test coverage for the critical sorting logic. Key Concerns:
Strengths:
Job Run | Branch: |
🔧 Changes
Fix handler execution order to ensure
clientGrantsprocesses beforelogStreamsSolution:
@order('70')decorator tologStreamsto ensure it executes afterclientGrants(priority 60)📚 References
🔬 Testing
📝 Checklist