Skip to content

Conversation

@kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Oct 8, 2025

🔧 Changes

Fixed keyword replacement handling for special $ sequences, which was causing corruption of keyword values containing these sequences (issue #1153).

Impact: Keyword replacement now correctly values containing special $ sequences, eliminating silent data corruption during multi-environment deployments.

📚 References

Fixes #1153

🔬 Testing

• New test cases added:

  • should handle dollar-apostrophe in replacement value — Validates string replacement preserves $' sequences
  • should handle dollar-apostrophe in array values — Validates array replacement preserves $' sequences in multiple array elements

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

- src/tools/utils.ts: use function-based replacement to handle $ sequences in keywordArrayReplace and keywordStringReplace
- test/tools/utils.test.js: add tests for handling dollar-apostrophe in replacement values for keywordStringReplace and keywordArrayReplace
@kushalshit27 kushalshit27 changed the title fix: improve keyword replacement handling for special characters fix: keyword replacement handling for special characters Oct 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.23%. Comparing base (2a4d28f) to head (ef2b85a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files         134      134           
  Lines        5096     5096           
  Branches     1013     1013           
=======================================
  Hits         4089     4089           
  Misses        578      578           
  Partials      429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@kushalshit27 kushalshit27 marked this pull request as ready for review October 8, 2025 15:16
@kushalshit27 kushalshit27 requested a review from a team as a code owner October 8, 2025 15:16
@kushalshit27 kushalshit27 merged commit d3231b5 into master Oct 10, 2025
7 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-1242-specific-keyword-replacements branch October 10, 2025 06:12
@kushalshit27 kushalshit27 mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error importing client with specific keyword replacements

4 participants