Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.3 does not include #16 #19

Open
aiotter opened this issue Oct 2, 2024 · 5 comments
Open

v0.7.3 does not include #16 #19

aiotter opened this issue Oct 2, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@aiotter
Copy link

aiotter commented Oct 2, 2024

It seems v0.7.3 is for #16 (65e9053), however 65e9053 is not on the history of 0.7.3 (81543e5).

@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Oct 3, 2024

Indeed. I will have to investigate why there are missing commits in the 0.7.3 tag, in the master branch the tag is clearly made after #16 was merged. At this point I do not see why the commit is not included when checking out the 0.7.3 tag.

@UncleGrumpy
Copy link
Collaborator

We really need to make another release in the near future, we will have to make sure that it includes all of the missing commits, and likely amend the CHANGELOG to reflect the release that the changes are actually included in.

Thank you so much for pointing this out, it has gone unnoticed for quite some time. ;-)

@UncleGrumpy UncleGrumpy added the bug Something isn't working label Oct 3, 2024
UncleGrumpy referenced this issue in UncleGrumpy/atomvm_packbeam Feb 15, 2025
Just bumps the version so we can make sure the 0.7.3 fixes are included this time. The tag for
0.6.3 did not include aoo of the commits since the 0.6.2 release. 0.6.3 was never released on
hex.pm, but we still need to bump the version to ensure no users end up using a cached version
from the 0.6.3 tag on GitHub.

Closes #19

Signed-off-by: Winford <[email protected]>
UncleGrumpy referenced this issue in UncleGrumpy/atomvm_packbeam Feb 15, 2025
Just bumps the version so we can make sure the 0.7.3 fixes are included this time. The tag for
0.6.3 did not include aoo of the commits since the 0.6.2 release. 0.6.3 was never released on
hex.pm, but we still need to bump the version to ensure no users end up using a cached version
from the 0.6.3 tag on GitHub.

Closes #19

Signed-off-by: Winford <[email protected]>
@karlsson
Copy link

It would be nice if you publish 0.7.4 on hex.pm too, once it is released. Seems 0.7.3 was not published.

@UncleGrumpy
Copy link
Collaborator

That is absolutely the plan! We had a temporary problem with not being able to release on hex.pm, but that is sorted out now. I did not release 0.7.3 to hex.pm late, because somehow that was a bad tag, and did not actually include the fix that it was intended to address. I did not want to try retagging the release on GitHub, since this could cause problems for users who had pulled the tag and had it cached.

I did discover a few housekeeping chores that I need to take care of before making this release.

@karlsson
Copy link

Thanks @UncleGrumpy ,
The 0.7.2 release works fine for me at the moment, so take your time 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants