🎨

Author: as-cii

spec/marker-layer-spec.coffee

@@ -176,7 +176,7 @@ describe "MarkerLayer", ->
       expect(layer2.findMarkers(containsPoint: [0, 4])).toEqual [layer2Marker]
 
   describe "::onDidUpdate", ->
-    it "notifies observers synchronously or at the end of a transaction when markers are created, updated, invalidated, or destroyed", ->
+    it "notifies observers synchronously or at the end of a transaction when markers are created, updated directly, updated indirectly, or destroyed", ->
       layer = buffer.addMarkerLayer({maintainHistory: true})
       events = []
       [marker1, marker2, marker3] = []

src/marker-layer.coffee

@@ -33,7 +33,7 @@ class MarkerLayer
 
   constructor: (@delegate, @id, options) ->
     @maintainHistory = options?.maintainHistory ? false
-    @destroytouchedMarkers = options?.destroytouchedMarkers ? false
+    @destroyInvalidatedMarkers = options?.destroyInvalidatedMarkers ? false
     @persistent = options?.persistent ? false
     @emitter = new Emitter
     @index = new MarkerIndex
@@ -259,7 +259,7 @@ class MarkerLayer
       marker = @markersById[id]
       @touchedMarkers.add(id)
       if invalidated[marker.getInvalidationStrategy()]?.has(id)
-        if @destroytouchedMarkers
+        if @destroyInvalidatedMarkers
           marker.destroy()
         else
           marker.valid = false

src/marker.coffee

@@ -102,12 +102,12 @@ class Marker
   #
   # Returns a {Disposable} on which `.dispose()` can be called to unsubscribe.
   onDidChange: (callback) ->
-    Grim.deprecate("""
-    Subscribing to marker change events is deprecated. Please, consider using
-    MarkerLayer.prototype.onDidUpdate instead.
-    """)
-
     unless @hasChangeObservers
+      Grim.deprecate("""
+      Subscribing to marker change events is deprecated. Please, consider using
+      `MarkerLayer.prototype.onDidUpdate` instead.
+      """)
+
       @previousEventState = @getSnapshot(@getRange())
       @hasChangeObservers = true
       @layer.markersIdsWithChangeSubscriptions.add(@id)