src: Do not set the --msvs_version= flag

In modern node-gyp, this flag only serves to limit
node-gyp to using a specific version of Visual Studio.

It can't make node-gyp find a version it wouldn't have found.

Our checks are much less sophisticated at detecting usable
installations of Visual Studio. We should let node-gyp
use the install of Visual Studio/Build Tools it thinks is best.

It will pick any usable Visual Studio install, preferring the newest
if multiple are installed and usable. It generally will not pick one
mistakenly that it actually can't use.

Given that the stakes are "we might prevent a valid installation
of Visual Studio from being used," and there is no benefit to be had,
this flag should not be set.

Author: DeeDeeG

src/ci.coffee

@@ -48,9 +48,6 @@ class Ci extends Command
     ]
     installArgs.push('--verbose') if options.argv.verbose
 
-    if vsArgs = @getVisualStudioFlags()
-      installArgs.push(vsArgs)
-
     fs.makeTreeSync(@atomDirectory)
 
     env = _.extend({}, process.env, {HOME: @atomNodeDirectory, RUSTUP_HOME: config.getRustupHomeDirPath()})

src/command.coffee

@@ -112,10 +112,6 @@ class Command
     env.npm_config_arch = config.getElectronArch()
     env.npm_config_target_arch = config.getElectronArch() # for node-pre-gyp
 
-  getVisualStudioFlags: ->
-    if vsVersion = config.getInstalledVisualStudioFlag()
-      "--msvs_version=#{vsVersion}"
-
   getNpmBuildFlags: ->
     ["--target=#{@electronVersion}", "--disturl=#{config.getElectronUrl()}", "--arch=#{config.getElectronArch()}"]
 

src/dedupe.coffee

@@ -43,9 +43,6 @@ class Dedupe extends Command
     dedupeArgs.push('--silent') if options.argv.silent
     dedupeArgs.push('--quiet') if options.argv.quiet
 
-    if vsArgs = @getVisualStudioFlags()
-      dedupeArgs.push(vsArgs)
-
     dedupeArgs.push(packageName) for packageName in options.argv._
 
     fs.makeTreeSync(@atomDirectory)

src/install.coffee

@@ -70,9 +70,6 @@ class Install extends Command
     installArgs.push('--quiet') if options.argv.quiet
     installArgs.push('--production') if options.argv.production
 
-    if vsArgs = @getVisualStudioFlags()
-      installArgs.push(vsArgs)
-
     fs.makeTreeSync(@atomDirectory)
 
     env = _.extend({}, process.env, {HOME: @atomNodeDirectory, RUSTUP_HOME: config.getRustupHomeDirPath()})
@@ -165,9 +162,6 @@ class Install extends Command
     installArgs.push('--quiet') if options.argv.quiet
     installArgs.push('--production') if options.argv.production
 
-    if vsArgs = @getVisualStudioFlags()
-      installArgs.push(vsArgs)
-
     fs.makeTreeSync(@atomDirectory)
 
     env = _.extend({}, process.env, {HOME: @atomNodeDirectory, RUSTUP_HOME: config.getRustupHomeDirPath()})
@@ -378,9 +372,6 @@ class Install extends Command
     buildArgs.push(path.resolve(__dirname, '..', 'native-module'))
     buildArgs.push(@getNpmBuildFlags()...)
 
-    if vsArgs = @getVisualStudioFlags()
-      buildArgs.push(vsArgs)
-
     fs.makeTreeSync(@atomDirectory)
 
     env = _.extend({}, process.env, {HOME: @atomNodeDirectory, RUSTUP_HOME: config.getRustupHomeDirPath()})

src/rebuild.coffee

@@ -38,9 +38,6 @@ class Rebuild extends Command
     rebuildArgs.push(@getNpmBuildFlags()...)
     rebuildArgs.push(options.argv._...)
 
-    if vsArgs = @getVisualStudioFlags()
-      rebuildArgs.push(vsArgs)
-
     fs.makeTreeSync(@atomDirectory)
 
     env = _.extend({}, process.env, {HOME: @atomNodeDirectory, RUSTUP_HOME: config.getRustupHomeDirPath()})