Add various Behat tests (#2044)

Author: mvorisek

.php-cs-fixer.dist.php

@@ -58,6 +58,8 @@
         // fn => without curly brackets is less readable,
         // also prevent bounding of unwanted variables for GC
         'use_arrow_functions' => false,
+
+        'phpdoc_var_without_name' => false, // remove once https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/6962 is merged
     ])
     ->setFinder($finder)
     ->setCacheFile(sys_get_temp_dir() . '/php-cs-fixer.' . md5(__DIR__) . '.cache');

demos/_includes/DemoLookup.php

@@ -16,7 +16,7 @@
 $crud->setModel($model);
 
 $crud->addModalAction(['icon' => 'book'], 'Edit product category', function (View $v, $id) use ($model) {
-    $entity = (clone $model)->load($id);
+    $entity = $model->load($id);
 
     $innerCrud = Crud::addTo($v);
     $innerCrud->setModel($entity->Products);

demos/_unit-test/crud-nested.php

@@ -61,7 +61,10 @@
     }
 });
 
-$table->addTotals(['name' => 'Totals:', 'salary' => ['sum']]);
+$table->addTotals([
+    'name' => 'Totals:',
+    'salary' => ['sum'],
+]);
 
 $myArray = [
     ['name' => 'Vinny', 'surname' => 'Sihra', 'birthdate' => '1973-02-03', 'cv' => 'I am <strong>BIG</strong> Vinny'],

demos/collection/table.php

@@ -49,7 +49,10 @@
 });
 
 $table->template->dangerouslyAppendHtml('Foot', $app->getTag('tr', ['class' => 'center aligned'], [['td', ['colspan' => '2'], 'This will appear above totals']]));
-$table->addTotals(['action' => 'Totals:', 'amount' => ['sum']]);
+$table->addTotals([
+    'action' => 'Totals:',
+    'amount' => ['sum'],
+]);
 
 Header::addTo($app, ['Columns with multiple formats', 'subHeader' => 'Single column can use logic to swap out formatters', 'icon' => 'table']);
 

demos/collection/table2.php

@@ -76,7 +76,7 @@
 $model = new Country($app->db);
 
 $group->addControl('Lookup_norm', [
-    DemoLookup::class,
+    Form\Control\Lookup::class,
     'model' => new Country($app->db),
     'plus' => true,
 ])->set($model->loadAny()->getId());

demos/form-control/input2.php

@@ -47,7 +47,11 @@
         }
     },
     'placeholder' => 'Selection depends on Dropdown above',
-    'search' => [Country::hinting()->fieldName()->name, Country::hinting()->fieldName()->iso, Country::hinting()->fieldName()->iso3],
+    'search' => [
+        Country::hinting()->fieldName()->name,
+        Country::hinting()->fieldName()->iso,
+        Country::hinting()->fieldName()->iso3,
+    ],
 ]);
 
 $form->onSubmit(function (Form $form) {
@@ -79,7 +83,11 @@
         }
     },
     'multiple' => true,
-    'search' => [Country::hinting()->fieldName()->name, Country::hinting()->fieldName()->iso, Country::hinting()->fieldName()->iso3],
+    'search' => [
+        Country::hinting()->fieldName()->name,
+        Country::hinting()->fieldName()->iso,
+        Country::hinting()->fieldName()->iso3,
+    ],
 ]);
 
 $form->onSubmit(function (Form $form) {

demos/form-control/lookup-dep.php

@@ -29,22 +29,23 @@
 
 $model = new Model($app->db, ['table' => 'test']);
 
-// Without Lookup
+// lookup without plus button
 $model->hasOne('country1', ['model' => [Country::class]]);
 
-// With Lookup
-$model->hasOne('country2', ['model' => [Country::class], 'ui' => ['form' => [
-    DemoLookup::class,
-    'plus' => true,
-]]]);
+// lookup with plus button
+$model->hasOne('country2', ['model' => [Country::class], 'ui' => ['form' => ['plus' => true]]]);
 
 $form->setModel($model->createEntity());
 
 $form->addControl('country3', [
     Form\Control\Lookup::class,
     'model' => new Country($app->db),
     'placeholder' => 'Search for country by name or iso value',
-    'search' => ['name', 'iso', 'iso3'],
+    'search' => [
+        Country::hinting()->fieldName()->name,
+        Country::hinting()->fieldName()->iso,
+        Country::hinting()->fieldName()->iso3,
+    ],
 ]);
 
 $form->onSubmit(function (Form $form) {

demos/form-control/lookup.php

@@ -513,10 +513,10 @@ The following will **not** work::
     // JsModal requires its contents to be put into a Virtual Page
     $vp = \Atk4\Ui\VirtualPage::addTo($app);
     $form = \Atk4\Ui\Form::addTo($vp);
-    $form->setModel(clone $model);
+    $form->setModel($model);
 
     $table = \Atk4\Ui\Table::addTo($app);
-    $table->setModel(clone $model));
+    $table->setModel($model));
 
     $button = \Atk4\Ui\Button::addTo($app, ['Add Item', 'icon' => 'plus']);
     $button->on('click', new \Atk4\Ui\Js\JsModal('JSModal Title', $vp));
@@ -537,11 +537,11 @@ Table needs to be first! The following works::
 
     // This needs to be first
     $table = \Atk4\Ui\Table::addTo($app);
-    $table->setModel(clone $model));
+    $table->setModel($model));
 
     $vp = \Atk4\Ui\VirtualPage::addTo($app);
     $form = \Atk4\Ui\Form::addTo($vp);
-    $form->setModel(clone $model);
+    $form->setModel($model);
 
     $button = \Atk4\Ui\Button::addTo($app, ['Add Item', 'icon' => 'plus']);
     $button->on('click', new \Atk4\Ui\Js\JsModal('JSModal Title', $vp));
@@ -566,7 +566,7 @@ VirtualPage content is rendered. To force yourself to put things in order you ca
     $vp = \Atk4\Ui\VirtualPage::addTo($app);
     $vp->set(function (\Atk4\Ui\VirtualPage $p) use ($table, $model) {
         $form = \Atk4\Ui\Form::addTo($p);
-        $form->setModel(clone $model);
+        $form->setModel($model);
         $form->onSubmit(function (Form $form) use ($table) {
             $form->model->save();
 

docs/js.rst

@@ -125,7 +125,10 @@ parameters:
             message: '~^Call to an undefined method Atk4\\Ui\\AbstractView&Atk4\\Ui\\UserAction\\ExecutorInterface::onHook\(\)\.$~'
         -
             path: 'src/Crud.php'
-            message: '~^Call to an undefined method Atk4\\Ui\\UserAction\\JsExecutorInterface::stickyGet\(\)\.$~'
+            message: '~^Call to an undefined method Atk4\\Ui\\AbstractView&Atk4\\Ui\\UserAction\\JsExecutorInterface::stickyGet\(\)\.$~'
+        -
+            path: 'src/Crud.php'
+            message: '~^Call to an undefined method Atk4\\Ui\\AbstractView&Atk4\\Ui\\UserAction\\ExecutorInterface::onHook\(\)\.$~'
         -
             path: 'src/Form.php'
             message: '~^Call to an undefined method Atk4\\Ui\\AbstractView::addButton\(\)\.$~'
@@ -300,6 +303,9 @@ parameters:
         -
             path: 'src/CardDeck.php'
             message: '~^Property Atk4\\Ui\\CardDeck::\$paginator \(Atk4\\Ui\\Paginator\|false\|null\) does not accept Atk4\\Ui\\AbstractView\.$~'
+        -
+            path: 'src/Form/Control/Input.php'
+            message: '~^Method Atk4\\Ui\\Form\\Control\\Input::prepareRenderButton\(\) should return Atk4\\Ui\\Button but returns \(Atk4\\Ui\\AbstractView&Atk4\\Ui\\UserAction\\ExecutorInterface\)\|Atk4\\Ui\\View\.$~'
         -
             path: 'src/Form/AbstractLayout.php'
             message: '~^Method Atk4\\Ui\\Form\\AbstractLayout::_addControl\(\) should return Atk4\\Ui\\Form\\Control but returns Atk4\\Ui\\View\.$~'