fix: remove bad nudges based on process grades, not outcomes

Removed "quality drops after 100 tool calls" — based on process grades
which are anti-correlated with shipping. Long sessions ship fine.

Removed "Spec Dump" nudge — skill expansions (/tdd, /ship etc) inflate
word counts, making short commands look like 500-word specs. The
archetype detection needs to filter skill text before this is useful.

Author: ateeples

sesh/live.py

@@ -338,20 +338,12 @@ def _generate_nudges(snap: LiveSnapshot) -> list[LiveNudge]:
                 f"{short} edited {count}x. Read the full file first?",
             ))
 
-    # Long session warning
-    if snap.duration_seconds > 7200:  # 2 hours
-        mins = int(snap.duration_seconds / 60)
-        nudges.append(LiveNudge(
-            "info",
-            f"Session: {mins} min. Quality tends to drop after 100 tool calls.",
-        ))
-
-    # Spec dump detection
-    if snap.archetype == "Spec Dump":
-        nudges.append(LiveNudge(
-            "info",
-            "Long prompts detected. Shorter directives + corrections ship more.",
-        ))
+    # NOTE: Removed "quality drops after 100 tool calls" nudge — that was
+    # based on process grades, not outcomes. Long sessions ship fine.
+    #
+    # NOTE: Removed "Spec Dump" nudge — skill expansions (/tdd, /ship etc)
+    # inflate word counts, making short commands look like spec dumps.
+    # The archetype detection needs to filter skill text before this is useful.
 
     # Positive reinforcement
     if snap.test_runs >= 3 and snap.test_passes >= 2 and not nudges:

tests/test_live.py

@@ -111,10 +111,11 @@ def test_file_thrashing(self):
         nudges = _generate_nudges(snap)
         assert any("edited" in n.message.lower() for n in nudges)
 
-    def test_long_session(self):
+    def test_long_session_no_false_warning(self):
+        """Long sessions should NOT warn about quality dropping — that was based on process grades."""
         snap = LiveSnapshot(tool_calls=20, duration_seconds=8000)
         nudges = _generate_nudges(snap)
-        assert any("min" in n.message for n in nudges)
+        assert not any("quality" in n.message.lower() for n in nudges)
 
     def test_clean_session_no_warn_nudges(self):
         snap = LiveSnapshot(tool_calls=10, test_runs=0)
@@ -130,13 +131,14 @@ def test_positive_feedback(self):
         nudges = _generate_nudges(snap)
         assert any("looking good" in n.message.lower() for n in nudges)
 
-    def test_spec_dump_nudge(self):
+    def test_spec_dump_no_false_nudge(self):
+        """Spec Dump nudge removed — skill expansions inflate word counts, making short commands look like specs."""
         snap = LiveSnapshot(
             tool_calls=20,
             archetype="Spec Dump",
         )
         nudges = _generate_nudges(snap)
-        assert any("shorter" in n.message.lower() for n in nudges)
+        assert not any("shorter" in n.message.lower() for n in nudges)
 
 
 class TestSnapshot: