Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README missing coverage of SANs entries validation #109

Closed
atc0005 opened this issue May 24, 2022 · 0 comments
Closed

README missing coverage of SANs entries validation #109

atc0005 opened this issue May 24, 2022 · 0 comments
Assignees
Labels
app/lscert bug Something isn't working documentation Improvements or additions to documentation plugin/check_cert
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented May 24, 2022

The lscert tool and the check_cert plugin both accept a CSV list of expected SANs entries and assert that:

  • all provided SANs entries are present on the leaf certificate
  • all SANs entries present on the leaf certificate are in the provided SANs entries list

This covers these scenarios:

  • the cert provider omitted a requested/expected SANs entry
  • the monitoring configuration has not been updated to look for new SANs entries present on the leaf cert

The README should ideally reflect both scenarios.

@atc0005 atc0005 added bug Something isn't working documentation Improvements or additions to documentation plugin/check_cert app/lscert labels May 24, 2022
@atc0005 atc0005 added this to the Future milestone May 24, 2022
@atc0005 atc0005 self-assigned this May 24, 2022
@atc0005 atc0005 modified the milestones: Future, v0.8.0 Jun 14, 2022
@atc0005 atc0005 closed this as completed Jun 27, 2022
@atc0005 atc0005 transferred this issue from another repository Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/lscert bug Something isn't working documentation Improvements or additions to documentation plugin/check_cert
Projects
None yet
Development

No branches or pull requests

1 participant