Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

December 2022 / January 2023 update (done) #514

Closed
1 task done
tima101 opened this issue Jan 1, 2023 · 0 comments
Closed
1 task done

December 2022 / January 2023 update (done) #514

tima101 opened this issue Jan 1, 2023 · 0 comments
Assignees

Comments

@tima101
Copy link
Member

tima101 commented Jan 1, 2023

  • packages, node, yarn, next.config.js, helmet (review: eslintrc.js and @babel/eslint-parser, stripe.ts, node-fetch, mongoose.set, helmet crossOriginEmbedderPolicy: false)
  • (explained in book 2, little sense to mention in book-1 since there is no App.getInitialProps method) comments on "shared initial data" and "per-page data"

getServerSideProps: cannot be used, error:
Error: You can not use getInitialProps with getServerSideProps. Please remove getInitialProps.

The withAuth HOC has to retire in its current form. Its authentication logic can be moved to _app.tsx. Example: https://github.com/async-labs/async/blob/main/app/pages/_app.tsx

See: vercel/next.js#10925


See: async-labs/saas#193

@tima101 tima101 self-assigned this Jan 1, 2023
tima101 added a commit that referenced this issue Jan 10, 2023
@klyburke klyburke changed the title December 2022 / January 2023 update December 2022 / January 2023 update (done) Mar 4, 2023
@tima101 tima101 closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant