Avoid overriding the exception message with the raw message (#1516)

Author: stof

src/Exception/InvalidArgumentException.php

@@ -3,19 +3,10 @@
 namespace AsyncAws\Firehose\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The specified input parameter has a value that is not valid.
  */
 final class InvalidArgumentException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/InvalidKMSResourceException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Firehose\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * Kinesis Data Firehose throws this exception when an attempt to put records or to start or stop delivery stream
@@ -12,15 +11,4 @@
  */
 final class InvalidKMSResourceException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['code']) ? (string) $data['code'] : null)) {
-            $this->code = $v;
-        }
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ResourceNotFoundException.php

@@ -3,19 +3,10 @@
 namespace AsyncAws\Firehose\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The specified resource could not be found.
  */
 final class ResourceNotFoundException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ServiceUnavailableException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Firehose\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The service is unavailable. Back off and retry the operation. If you continue to see the exception, throughput limits
@@ -14,12 +13,4 @@
  */
 final class ServiceUnavailableException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }