Skip to content

Commit 29a8b37

Browse files
authored
🔀 Merge pull request #74 from astariul/fix_readme2
Fix pages not able to read public readme due to version / tags discrepancy (2)
2 parents d9795c5 + 2e99e32 commit 29a8b37

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

‎.github/actions.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,14 @@ def update(pkg_name, version):
138138
new_div = copy.copy(original_div)
139139
anchor = new_div.find('a')
140140
new_div['onclick'] = f"load_readme('{version}', scroll_to_div=true);"
141-
new_div['id'] = norm_version
141+
new_div['id'] = version
142142
new_div['class'] = ""
143143
if not is_stable(version):
144144
new_div['class'] += "prerelease"
145145
else:
146146
# replace the latest main version
147147
main_version_span = soup.find('span', id='latest-main-version')
148-
main_version_span.string = norm_version
148+
main_version_span.string = version
149149
anchor.string = norm_version
150150
anchor['href'] = f"git+{link}@{version}#egg={norm_pkg_name}-{norm_version}"
151151

@@ -154,7 +154,7 @@ def update(pkg_name, version):
154154

155155
# Change the latest version (if stable)
156156
if is_stable(version):
157-
soup.html.body.div.section.find_all('span')[1].contents[0].replace_with(norm_version)
157+
soup.html.body.div.section.find_all('span')[1].contents[0].replace_with(version)
158158

159159
# Save it
160160
with open(index_file, 'wb') as index:

‎mydependency/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<span>
4646
</span>
4747
<span id='latest-version' class="version">
48-
1.0
48+
v1.0
4949
</span>
5050
<span id='latest-main-version' hidden>
5151
1.0
@@ -79,7 +79,7 @@
7979
Nicolas Remond
8080
</p>
8181
<section class="versions" id="versions">
82-
<div id="1.0" onclick="load_readme('v1.0', scroll_to_div=true)">
82+
<div id="v1.0" onclick="load_readme('v1.0', scroll_to_div=true)">
8383
<a href="git+https://github.com/astariul/[email protected]#egg=mydependency-1.0">
8484
1.0
8585
</a>

‎pkg_template.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<span>
4646
</span>
4747
<span id='latest-version' class="version">
48-
_norm_version
48+
_version
4949
</span>
5050
<span id='latest-main-version' hidden>
5151
_latest_main
@@ -79,7 +79,7 @@
7979
_author
8080
</p>
8181
<section class="versions" id="versions">
82-
<div id="_norm_version" onclick="load_readme('_version', scroll_to_div=true)">
82+
<div id="_version" onclick="load_readme('_version', scroll_to_div=true)">
8383
<a href="_link">
8484
_norm_version
8585
</a>

‎private-hello/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<span>
4646
</span>
4747
<span id='latest-version' class="version">
48-
0.4.5
48+
v0.4.5
4949
</span>
5050
<span id='latest-main-version' hidden>
5151
0.4.5
@@ -79,7 +79,7 @@
7979
Nicolas Remond
8080
</p>
8181
<section class="versions" id="versions">
82-
<div id="0.4.5" onclick="load_readme('v0.4.5', scroll_to_div=true)">
82+
<div id="v0.4.5" onclick="load_readme('v0.4.5', scroll_to_div=true)">
8383
<a href="git+https://github.com/astariul/[email protected]#egg=private-hello-0.4.5">
8484
0.4.5
8585
</a>

‎transformers/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<span>
4646
</span>
4747
<span id='latest-version' class="version">
48-
3.0.0
48+
v3.0.0
4949
</span>
5050
<span id='latest-main-version' hidden>
5151
3.0.0
@@ -79,7 +79,7 @@
7979
Nicolas Remond
8080
</p>
8181
<section class="versions" id="versions">
82-
<div id="3.0.0" onclick="load_readme('v3.0.0', scroll_to_div=true)">
82+
<div id="v3.0.0" onclick="load_readme('v3.0.0', scroll_to_div=true)">
8383
<a href="git+https://github.com/huggingface/[email protected]#egg=transformers-3.0.0">
8484
3.0.0
8585
</a>

0 commit comments

Comments
 (0)