-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libman: library could not be resolved by 'cdnjs' provider AGAIN #711
Comments
Hi @jimmylewis ! Is there any chance of seeing this bug fixed ? It impacts all people who are forced to use old TLS version for various reasons. Unfortunately in some work environments, software upgrades are not easily done. |
FYI: I've created my own libman visual studio extension package and replaced it on mine system ;). Hardcoded required TLS and got the result. |
@LLIAMAH great job ! Why don't you submit it in a pull request 😊 |
Cause it has hardcoded inset for few private cases only. |
I'm thinking that this could be done as a setting e.g. do something like One issue however is that using @LLIAMAH does it work if you add
after line 61 instead? Since I can't reproduce the problem, I can't tell if this would resolve it, but I'm trying to limit the impact to only the libman web requests. |
Per aspnet#711 (and aspnet#699 before it), some users need to force TLS 1.2 for libman to work. This change adds a new user setting, "forcetls12", which will set libman to use TLS1.2 for any HttpClient it creates. I verified via WireShark that the traffic to services (cdnjs, etc) that libman calls to switched from 1.3 (my system default) to 1.2 when this setting was in place, and returned to 1.3 by unsetting it. I could also see that other connections from within VS were still using TLS1.3 so we didn't affect other components on accident.
@LLIAMAH I made a draft PR that I think implements this so it addresses my concerns. Can you give it a try and see if it solves the problem for you? To force TLS 1.2, you need to use the libman CLI to do |
Yes. Exactly this one line. |
The GUI will respect the setting, but the only way to configure libman settings like this for now is to use the CLI to set or unset the value. Implementing a GUI for editing settings would need to be a separate feature. |
@carloswm85 yes they fixed it - I saw commit in which been defined some TLS as by default, but I don't know - is it in release build or not. Did you tried this one comand? To define libman config option? And don't forget to restart VS after config changed. |
Describe the bug
Some time ago I got the problem: #699
After some actions I received required libs and all was OK, but - in one time I have to add NEW one lib and was surprised that received same error.
I'll checked another libs:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Additional context
I started to investigate and TADAM! Problem in security certificates AGAIN! So it is from minor-middle bug, should increase priority and fixed in result, I guess.
I don't know why forced set options to TLS 1.2 doesn't work anymore (this helped in past) - may be after installing latest Win10 updates. But in current moment I could take NEW libs ONLY via libman Debug + dependent VS opened solution with this row.
I downloaded libman codes, started it and found that:
I UNDERLINE: that ALL 3 problems of the
are WORKED FINE for me if Row#59 exists. So would be nice to have option to force switching it on.
The text was updated successfully, but these errors were encountered: