Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to PRs? #141

Open
grounded042 opened this issue Dec 8, 2024 · 6 comments
Open

Open to PRs? #141

grounded042 opened this issue Dec 8, 2024 · 6 comments

Comments

@grounded042
Copy link
Contributor

This project hasn't had any activity in ~3 years. Are you open to PRs? I've done a chunk of work to update things to work with the latest iOS. Happy to contribute it back to this repo if it's open to PRs.

@ashtom
Copy link
Owner

ashtom commented Dec 16, 2024

Yes, please send PRs. I should have time over the holidays to review and merge.

@grounded042
Copy link
Contributor Author

Great to hear! I've forked and put a bunch of changes into main...fitnesstotals:hkimport:main.

I will work on breaking that out into smaller PRs over the holidays.

@grounded042
Copy link
Contributor Author

First PR updating basic workout import: #142

I'll have more coming throughout the week. They'll all build on the first PR here since it adds testing support.

@grounded042
Copy link
Contributor Author

Next PR: #143 to handle more advanced workout data.

@ashtom
Copy link
Owner

ashtom commented Dec 30, 2024

@grounded042 Thanks so much, just merged both of them and tested in my local setup. Happy New Year!

@grounded042
Copy link
Contributor Author

grounded042 commented Jan 1, 2025

@ashtom thank you for the merge and Happy New Year as well! One more for ya: #144

Also, two questions:

  1. Any interest in updating the minimum deployment iOS version from 12.0 to a newer version of iOS? There aren't any issues targeting 12.0, but it's no longer supported by Apple.
  2. Would you be ok if I updated the project to use SwiftUI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants