fix: ensure aggregates are unique by name before adding

zachdaniel · zachdaniel · commit 890fac04f9ec · 2025-10-14T23:06:57.000-04:00
diff --git a/lib/aggregate.ex b/lib/aggregate.ex
@@ -68,7 +68,9 @@ defmodule AshSql.Aggregate do
           )
 
         {already_computed_aggregates, remaining_aggregates} =
-          Enum.split_with(aggregates, &already_added?(&1, query.__ash_bindings__, []))
+          aggregates
+          |> Enum.uniq_by(& &1.name)
+          |> Enum.split_with(&already_added?(&1, query.__ash_bindings__, []))
 
         query =
           if Enum.any?(already_computed_aggregates) do

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ defmodule AshSql.Aggregate do`
`68`	`68`	`)`
`69`	`69`
`70`	`70`	`{already_computed_aggregates, remaining_aggregates} =`
`71`		`- Enum.split_with(aggregates, &already_added?(&1, query.__ash_bindings__, []))`
	`71`	`+ aggregates`
	`72`	`+ \|> Enum.uniq_by(& &1.name)`
	`73`	`+ \|> Enum.split_with(&already_added?(&1, query.__ash_bindings__, []))`
`72`	`74`
`73`	`75`	`query =`
`74`	`76`	`if Enum.any?(already_computed_aggregates) do`