chore: update tests to account for warnings

Author: zachdaniel

test/aggregate_test.exs

@@ -1,5 +1,6 @@
 defmodule AshSql.AggregateTest do
   use AshPostgres.RepoCase, async: false
+  import ExUnit.CaptureIO
   alias AshPostgres.Test.{Author, Comment, Organization, Post, Rating, User}
 
   require Ash.Query
@@ -970,37 +971,41 @@ defmodule AshSql.AggregateTest do
   end
 
   test "can't define multidimensional array aggregate types" do
-    assert_raise Spark.Error.DslError, ~r/Aggregate not supported/, fn ->
-      defmodule Foo do
-        @moduledoc false
-        use Ash.Resource,
-          domain: nil,
-          data_layer: AshPostgres.DataLayer
-
-        postgres do
-          table("profile")
-          repo(AshPostgres.TestRepo)
-        end
+    # This used to raise an error, but now should only emit a warning and allow the module to compile
+    {_, io} =
+      with_io(:stderr, fn ->
+        defmodule Foo do
+          @moduledoc false
+          use Ash.Resource,
+            domain: nil,
+            data_layer: AshPostgres.DataLayer
+
+          postgres do
+            table("profile")
+            repo(AshPostgres.TestRepo)
+          end
 
-        attributes do
-          uuid_primary_key(:id, writable?: true)
-        end
+          attributes do
+            uuid_primary_key(:id, writable?: true)
+          end
 
-        actions do
-          defaults([:create, :read, :update, :destroy])
-        end
+          actions do
+            defaults([:create, :read, :update, :destroy])
+          end
 
-        relationships do
-          belongs_to(:author, AshPostgres.Test.Author) do
-            public?(true)
+          relationships do
+            belongs_to(:author, AshPostgres.Test.Author) do
+              public?(true)
+            end
           end
-        end
 
-        aggregates do
-          first(:author_badges, :author, :badges)
+          aggregates do
+            first(:author_badges, :author, :badges)
+          end
         end
-      end
-    end
+      end)
+
+    assert io =~ "Aggregate not supported"
   end
 
   test "related aggregates can be filtered on" do

test/references_test.exs

@@ -1,5 +1,6 @@
 defmodule AshPostgres.ReferencesTest do
   use AshPostgres.RepoCase
+  import ExUnit.CaptureIO
 
   test "can't use match_type != :full when referencing an non-primary key index" do
     Code.compiler_options(ignore_module_conflict: true)
@@ -66,44 +67,47 @@ defmodule AshPostgres.ReferencesTest do
       end
     end
 
-    assert_raise Spark.Error.DslError, ~r/Unsupported match_type./, fn ->
-      defmodule UserThing do
-        @moduledoc false
-        use Ash.Resource,
-          domain: nil,
-          data_layer: AshPostgres.DataLayer
-
-        attributes do
-          attribute(:id, :string, primary_key?: true, allow_nil?: false, public?: true)
-          attribute(:name, :string, public?: true)
-          attribute(:org_id, :uuid, public?: true)
-          attribute(:foo_id, :uuid, public?: true)
-        end
+    {_, io} =
+      with_io(:stderr, fn ->
+        defmodule UserThing do
+          @moduledoc false
+          use Ash.Resource,
+            domain: nil,
+            data_layer: AshPostgres.DataLayer
+
+          attributes do
+            attribute(:id, :string, primary_key?: true, allow_nil?: false, public?: true)
+            attribute(:name, :string, public?: true)
+            attribute(:org_id, :uuid, public?: true)
+            attribute(:foo_id, :uuid, public?: true)
+          end
 
-        multitenancy do
-          strategy(:attribute)
-          attribute(:org_id)
-        end
+          multitenancy do
+            strategy(:attribute)
+            attribute(:org_id)
+          end
 
-        relationships do
-          belongs_to(:org, Org)
-          belongs_to(:user, User, destination_attribute: :secondary_id)
-        end
+          relationships do
+            belongs_to(:org, Org)
+            belongs_to(:user, User, destination_attribute: :secondary_id)
+          end
 
-        postgres do
-          table("user_things")
-          repo(AshPostgres.TestRepo)
+          postgres do
+            table("user_things")
+            repo(AshPostgres.TestRepo)
 
-          references do
-            reference :user, match_with: [foo_id: :foo_id], match_type: :simple
+            references do
+              reference :user, match_with: [foo_id: :foo_id], match_type: :simple
+            end
           end
-        end
 
-        actions do
-          defaults([:create, :read, :update, :destroy])
+          actions do
+            defaults([:create, :read, :update, :destroy])
+          end
         end
-      end
-    end
+      end)
+
+    assert io =~ "Unsupported match_type"
   end
 
   test "named reference results in properly applied foreign_key_constraint/3 on the underlying changeset" do