Skip to content

fix: added bulk_action_ref for changeset lookups #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2025
Merged

fix: added bulk_action_ref for changeset lookups #2411

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cdd948
fix: added bulk_action_ref for changeset lookups
DGollings Oct 26, 2025
e3cd8ad
fix: unrelated dialyzer issues
DGollings Oct 27, 2025
462f984
workaround: add no_opaque to dialyzer options until dialyzer issue is…
DGollings Oct 27, 2025
dbc9d9f
improvement: use bulk_metadata ref added to changesets
DGollings Oct 31, 2025
ea31926
improvement: add backwards compatibility for data layers returning on…
DGollings Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ash/action_input.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ defmodule Ash.ActionInput do
resource: Ash.Resource.t(),
invalid_keys: MapSet.t(),
context: map(),
domain: Ash.Domain.t(),
domain: Ash.Domain.t() | nil,
valid?: boolean(),
errors: [Ash.Error.t()],
before_action: [before_action_fun],
Expand Down Expand Up @@ -132,7 +132,7 @@ defmodule Ash.ActionInput do
- `set_argument/3` for adding arguments
- `set_context/2` for adding context
"""
@spec new(Ash.Resource.t(), Ash.Domain.t()) :: t
@spec new(Ash.Resource.t(), Ash.Domain.t() | nil) :: t
def new(resource, domain \\ nil) do
%__MODULE__{resource: resource, domain: domain}
end
Expand Down
16 changes: 12 additions & 4 deletions lib/ash/actions/bulk_manual_action_helpers.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,21 +87,29 @@ defmodule Ash.Actions.BulkManualActionHelpers do
case result do
{:ok, record} ->
record =
Ash.Resource.put_metadata(
record,
record
|> Ash.Resource.put_metadata(
metadata_index_name,
changeset.context[bulk_action_type].index
)
|> Ash.Resource.put_metadata(
:bulk_action_ref,
changeset.context[bulk_action_type].ref
)

{:ok, record}

{:ok, record, notifications} ->
record =
Ash.Resource.put_metadata(
record,
record
|> Ash.Resource.put_metadata(
metadata_index_name,
changeset.context[bulk_action_type].index
)
|> Ash.Resource.put_metadata(
:bulk_action_ref,
changeset.context[bulk_action_type].ref
)

{:ok, record, notifications}

Expand Down
Loading