-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSED] Replace ERD (Haskell) with erd-go #402
Comments
|
WDYT? @pepijnve @mojavelinux |
That makes a whole lot of sense. Should simplify (and significantly shorten) the CI builds as well. Installing the Haskell environment eats up a lot of time just for |
Used and testable via Docker Image https://hub.docker.com/r/uwebarthel/asciidoctor/ Github project (Dockerfile): https://github.com/barthel/docker-asciidoctor |
#402 Add erd-go as alternative to erd
Hello folks, sorry for being a party crasher bu you might want to look at asciidoctor/docker-asciidoctor#343 (comment) . It is hard to evaluate the safety of A cleanup of the golang version and its gomod version (dependabot) would also clearly help. @barthel Are you up to the challenge? |
@dduportal I understand the concern. Not really an issue for the diagram extension itself since it supports both the Haskell and Go version now preferring the former over the latter. |
@dduportal You are not a party chrasher. Security concerns are important and valid at any time. The goal of using Let's discuss in asciidoctor/docker-asciidoctor#343 (comment) |
Challange accepted for a more than less platform independent Asciidoctor. |
As part of asciidoctor/docker-asciidoctor#51 I have been trying to create a multi-platform Asciidoctor Docker image.
In doing so,
erd
(https://github.com/BurntSushi/erd) was a challenge, as there is only onex86
platform variant.To remove this limitation, I looked at
erd-go
(https://github.com/kaishuu0123/erd-go/) and included it.Since it supports the same CLI parameters, replacing the executable was enough.
To further promote platform independence, I would like to propose an official switch to or support of
erd-go
.The text was updated successfully, but these errors were encountered: