Strange "implicit" wording in doco for a2x --fop option

[apjanke]

Here's the a2x man page's description of --fop.

   --fop
       Use FOP to generate PDFs. The default behavior is to use dblatex(1). The --fop
       option is implicit if this option is used.

The last sentence about the option being implicit is confusing to me. This option implicitly enables itself? Is one of the option names here wrong? Looking at the a2x.py code, it looks like --fopt-opts implicitly enables --fop, so that sentence should be moved to the description for --fop-opts.

[elextr]

I'm sure this has been mentioned before, but maybe it was pre-github or no patch was produced.

The --fop-opts description already says "If this option is specified FOP is used to generate PDFs.". So I think its just a case of replacing "this option" in the --fop description with "--fop-opts".

[rrthomas]

I just noticed this problem myself. Is there some reason it has not yet been fixed? @elextr's solution seems fine to me.

[elextr]

Basically nobody bothered to provide a pull request for it, fixed in asciidoc-py/asciidoc-py@6896335

[rrthomas]

Thanks! In this case it would seem quicker to fix it yourself than read a pull request, otherwise I would happily have provided one. (Also, I'm waiting for my first pull request to be processed, because otherwise it does not seem worth providing more…)

[elextr]

I certainly didn't mean to imply that you yourself should have made a PR, but the issue has been there for almost two years. Asciidoc has no full time contributors or maintainers so it doesn't matter how little effort it took to do, until somebody does it it won't happen.

I presume your other PR is #126 see new comment for how to proceed.

[mojavelinux]

Asciidoc has no full time contributors or maintainers

To clarify for those who might get confused, that refers to AsciiDoc Python ;)

Asciidoctor is where development on AsciiDoc is being continued and is very much alive.

[elextr]

@mojavelinux yes, was entirely referring to Asciidoc Python, sorry :)

[mojavelinux]

No need to apologize. I know you know that. I just wanted to make sure we leave a trail of breadcrumbs for others following along.