-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE Compatibility #3
Comments
Hi there, |
same for safari ... |
thanks to @marcgara IE10+ are supported now, |
Any chance to make it work on IE9 ? |
I've just give it a try on IE10, the generated CSV file is wrong. Instead of a multi-line CSV file, there is single continuous line. |
What version did you use ? |
0.2.3 and 0.2.2. |
Probably IE is not complient with the data uri standard, Anyway, I'll go over the IE behavior. |
as workaround, On : function doClick() {
if(window.navigator.msSaveOrOpenBlob) {
var blob = new Blob([scope.csv], {
(...) I modify the blob creation to decode the CSV again : |
@bingenortuzar Work perfectly, thank |
Do you want to pull request your patch ? |
Done (or at least I think so :) ) |
Hi, |
I haven't released a new version yet. have you tried using the latest source code ? |
Yes I added "var blob = new Blob([decodeURIComponent(scope.csv)],{" change from last pull request. It made it produce valid CSV in IE but looks like BOM is missing although I'm using add-bom. |
Thank you very much for this directive .I used the latest updated version. |
@barbecube I don't need BOOM, and no time now to try, but looking into code, saw: if(window.navigator.msSaveOrOpenBlob) {
csv = csvContent;
}else{
csv = DATA_URI_PREFIX;
if (options.addByteOrderMarker){
csv += BOM;
}
csv += csvContent;
}
def.resolve(csv);
}); as you can see, the BOOM is not included for Blob downloads. if(!window.navigator.msSaveOrOpenBlob) {
csv = DATA_URI_PREFIX;
}
else
{
csv = ''
}
if (options.addByteOrderMarker){
csv += BOM;
}
csv += csvContent;
def.resolve(csv);
}); |
Working with fix like as below? ng-csv not working in my IE.
|
nop! |
Sorry for my late response, easy to miss comments in a closed pull request. |
for download attribut: http://caniuse.com/#search=download%20attribute if somebody is interrested by using ng-csv supported by all bowser (also ie<10)
|
Hi BerangereMartin, Can you provide as a plunker , on how to used code , you have provided Thanks |
Same issue here. I am trying to use this directive in IE9. Doesn't work. Can someone post a plunker with the hack they did to make it work? |
See my pull request i am sorry but no Time to make a plunker |
Is this fix being merged soon? Pull request: #150 |
Nice little directive! However, it doesn't seem to be working in internet explorer at the moment. Is there any plan to modify it to work for IE?
The text was updated successfully, but these errors were encountered: