Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling factor logic in vehicle link count #238

Open
syhwawa opened this issue Feb 4, 2025 · 0 comments · May be fixed by #239
Open

Scaling factor logic in vehicle link count #238

syhwawa opened this issue Feb 4, 2025 · 0 comments · May be fixed by #239
Labels
bug Something isn't working

Comments

@syhwawa
Copy link
Contributor

syhwawa commented Feb 4, 2025

The current scaling logic in the code for link_vehicle_counts here is designed to handle cars and PT modes.
This leads to issues where non-PT modes such as bike, taxi, and walk are not scaled properly.

scale_factor = self.config.scale_factor
if self.mode != "car":
    scale_factor = 1.0

We observed that modes for bikes are not scaled. And non-public transport modes (including taxi, bike, and walk) should be appropriately scaled.

It may need a better name for the event handler e.g mode_link_counts if we would like to use this to get the links count for other modes.

When vehicle_link_counts produced the link counts output for taxi, it seems wrong since all the counts are equal to zero. Worth to check the logic for non-car mode.

@syhwawa syhwawa added the bug Something isn't working label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant