You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current scaling logic in the code for link_vehicle_counts here is designed to handle cars and PT modes.
This leads to issues where non-PT modes such as bike, taxi, and walk are not scaled properly.
scale_factor = self.config.scale_factor
if self.mode != "car":
scale_factor = 1.0
We observed that modes for bikes are not scaled. And non-public transport modes (including taxi, bike, and walk) should be appropriately scaled.
It may need a better name for the event handler e.g mode_link_counts if we would like to use this to get the links count for other modes.
When vehicle_link_counts produced the link counts output for taxi, it seems wrong since all the counts are equal to zero. Worth to check the logic for non-car mode.
The text was updated successfully, but these errors were encountered:
The current scaling logic in the code for link_vehicle_counts here is designed to handle cars and PT modes.
This leads to issues where non-PT modes such as
bike
,taxi
, andwalk
are not scaled properly.We observed that modes for bikes are not scaled. And non-public transport modes (including taxi, bike, and walk) should be appropriately scaled.
It may need a better name for the event handler e.g
mode_link_counts
if we would like to use this to get the links count for other modes.When
vehicle_link_counts
produced the link counts output fortaxi
, it seems wrong since all the counts are equal to zero. Worth to check the logic for non-car mode.The text was updated successfully, but these errors were encountered: