Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capacity definition structure change in transit_vehicles.xml #188

Open
elizabethc-arup opened this issue Mar 5, 2022 · 1 comment
Open
Labels
bug Something isn't working question Further information is requested

Comments

@elizabethc-arup
Copy link
Contributor

Hello,

I have noticed that there is a change in how the capacity is defined in the transit_vehicles.xml file (please see below):

  • Old definition:

image

  • New definition:

image

This has caused an error when retrieving the vehicle capacity using the transform_veh_type_elem function in the inputs.py file when running the code on the newly defined transit_vehicles.xml

elara/elara/inputs.py

Lines 466 to 467 in 9a68ece

seated_capacity = float(elem.xpath("capacity/seats/@persons")[0])
standing_capacity = float(elem.xpath("capacity/standingRoom/@persons")[0])

@elizabethc-arup elizabethc-arup added bug Something isn't working question Further information is requested labels Mar 5, 2022
@mfitz
Copy link
Contributor

mfitz commented Mar 23, 2022

This is as per the change from version 1.0 of the vehicle definitions schema to version 2.0. We should have elara support both versions of this schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants