New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging to benchmarking.CSVComparison #147

Open

fredshone opened this issue Oct 13, 2021 · 0 comments

Assignees

Collaborator

fredshone commented Oct 13, 2021

The CSV comparison class (here) has no logging (other than what it receives from it's parent class.

This led to a difficult to resolve bug where input benchmark data had the wrong column names.

Suggest:

i) add better logging (not necessarily more, unless in debug)
ii) consider not crashing when broken bm data is found - NOT SURE ABOUT THIS THOUGH

fredshone self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment