Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute sliced mode share summing to 1 for each attribute class #143

Open
elizabethc-arup opened this issue Sep 21, 2021 · 0 comments
Open

Comments

@elizabethc-arup
Copy link
Contributor

For the NZ ABM, we are looking to build a regional benchmark to compare the mode shares within each region. This BM makes use of the destination_mode_shares_comparison BM with the groupby_person_attributes parameter to group the mode shares by region.

The output of the current implementation of the handler/ BM sums the mode shares for all classes to 1, however, for our particular instance, we would like to alter it so that the mode shares sum to 1 per region (class) to allow for the comparisons regionally.

From what I understand, there seems to be two ways to implement this case, with the first being to implement it as a separate NZ-specific BM in the benchmarking.py and the other to implement it as a more general case - perhaps involving a boolean parameter or a separate handler class to enable this option. I was wondering which would be the more suitable option of implementation in the best interest of Elara?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant