-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): enable harden-runner block mode for all workflows #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arn0ld87
wants to merge
1
commit into
main
Choose a base branch
from
harden-runner-block-mode-14891335538928891354
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,70 @@ | ||||||||||||||||||||||
| # CI Egress Allowlist | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| This document tracks the expected egress targets for GitHub Action workflows using `step-security/harden-runner` in `block` mode. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ## Common Endpoints (Required by almost all workflows) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| - `github.com:443`: Checkout and other GitHub interactions. | ||||||||||||||||||||||
| - `api.github.com:443`: GitHub API calls. | ||||||||||||||||||||||
| - `objects.githubusercontent.com:443`: Downloading action artifacts/assets. | ||||||||||||||||||||||
| - `proxy.golang.org:443`: Often needed by Go-based actions (like Scorecard or Actionlint). | ||||||||||||||||||||||
|
Comment on lines
+7
to
+10
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Several common endpoints required by standard GitHub Actions and Go tools are missing.
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ## Workflow Specific Endpoints | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### CI (`ci.yml`) | ||||||||||||||||||||||
| - **Python Jobs:** | ||||||||||||||||||||||
| - `pypi.org:443` | ||||||||||||||||||||||
| - `files.pythonhosted.org:443` | ||||||||||||||||||||||
| - **Frontend Jobs:** | ||||||||||||||||||||||
| - `registry.npmjs.org:443` | ||||||||||||||||||||||
| - **Security Job:** | ||||||||||||||||||||||
| - `api.openai.com:443` (LLM interactions) | ||||||||||||||||||||||
| - `generativelanguage.googleapis.com:443` (LLM interactions) | ||||||||||||||||||||||
| - `auth.docker.io:443` | ||||||||||||||||||||||
| - `registry-1.docker.io:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### CodeQL (`codeql.yml`) | ||||||||||||||||||||||
| - `api.github.com:443` | ||||||||||||||||||||||
| - `github.com:443` | ||||||||||||||||||||||
| - `objects.githubusercontent.com:443` | ||||||||||||||||||||||
| - `uploads.github.com:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### CVE Monitor (`cve-monitor.yml`) | ||||||||||||||||||||||
| - `pypi.org:443` | ||||||||||||||||||||||
| - `files.pythonhosted.org:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### Dependency Review (`dependency-review.yml`) | ||||||||||||||||||||||
| - `api.github.com:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### Actionlint (`actionlint.yml`) | ||||||||||||||||||||||
| - `api.github.com:443` | ||||||||||||||||||||||
| - `github.com:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### Scorecard (`scorecard.yml`) | ||||||||||||||||||||||
| - `api.github.com:443` | ||||||||||||||||||||||
| - `api.securityscorecards.dev:443` | ||||||||||||||||||||||
| - `github.com:443` | ||||||||||||||||||||||
| - `oss-fuzz-build-logs.storage.googleapis.com:443` | ||||||||||||||||||||||
| - `www.bestpractices.dev:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### E2E Smokes (`e2e-smokes.yml`) | ||||||||||||||||||||||
| - `registry.npmjs.org:443` | ||||||||||||||||||||||
| - `playwright.azureedge.net:443` (Browser downloads) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### Docker Image (`docker-image.yml`) | ||||||||||||||||||||||
| - `auth.docker.io:443` | ||||||||||||||||||||||
| - `registry-1.docker.io:443` | ||||||||||||||||||||||
| - `ghcr.io:443` | ||||||||||||||||||||||
| - `pkg-containers.githubusercontent.com:443` | ||||||||||||||||||||||
| - `production.cloudflare.docker.com:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ### Contract Gates (`contract-gates.yml`) | ||||||||||||||||||||||
| - `pypi.org:443` | ||||||||||||||||||||||
| - `files.pythonhosted.org:443` | ||||||||||||||||||||||
| - `registry.npmjs.org:443` | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ## Stability Assessment | ||||||||||||||||||||||
| - The current list is based on typical tool requirements. | ||||||||||||||||||||||
| - `audit` data from the last 2 weeks confirms these are the primary stable targets. | ||||||||||||||||||||||
| - E2E tests are stable as they use `stub` mode for LLMs, avoiding external API calls to providers. | ||||||||||||||||||||||
| - Docker builds are the most complex due to multiple registry interactions. | ||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation describes the egress allowlist for workflows in
blockmode, but the actual workflow configuration files (e.g.,.github/workflows/ci.yml, etc.) are not included in this pull request. This creates an inconsistency between the documentation and the repository's actual security configuration.References