fix(vanishing_poly): compute x^2 - h^2 when dim_h == 1 in evaluate_constraints (#186)

* fix(vanishing_poly): compute x^2 - h^2 when dim_h == 1 in evaluate_constraints

* Update vanishing_poly.rs

---------

Co-authored-by: Pratyush Mishra <[email protected]>

Author: phrwlk

src/poly/domain/vanishing_poly.rs

@@ -1,7 +1,6 @@
 use crate::fields::{fp::FpVar, FieldVar};
 use ark_ff::{Field, PrimeField};
 use ark_relations::gr1cs::SynthesisError;
-use ark_std::ops::Sub;
 
 /// Struct describing vanishing polynomial for a multiplicative coset H where
 /// |H| is a power of 2. As H is a coset, every element can be described as
@@ -39,11 +38,6 @@ impl<F: PrimeField> VanishingPolynomial<F> {
     /// Caution for use in holographic lincheck: The output has 2 entries in one
     /// matrix
     pub fn evaluate_constraints(&self, x: &FpVar<F>) -> Result<FpVar<F>, SynthesisError> {
-        if self.dim_h == 1 {
-            let result = x.sub(x);
-            return Ok(result);
-        }
-
         let mut cur = x.square()?;
         for _ in 1..self.dim_h {
             cur.square_in_place()?;
@@ -76,4 +70,18 @@ mod tests {
         assert!(cs.is_satisfied().unwrap());
         assert_eq!(result_var.value().unwrap(), native);
     }
+
+    #[test]
+    fn constraints_test_dim1() {
+        let mut rng = test_rng();
+        let offset = Fr::rand(&mut rng);
+        let cs = ConstraintSystem::new_ref();
+        let x = Fr::rand(&mut rng);
+        let x_var = FpVar::new_witness(ns!(cs, "x_var"), || Ok(x)).unwrap();
+        let vp = VanishingPolynomial::new(offset, 1);
+        let native = vp.evaluate(&x);
+        let result_var = vp.evaluate_constraints(&x_var).unwrap();
+        assert!(cs.is_satisfied().unwrap());
+        assert_eq!(result_var.value().unwrap(), native);
+    }
 }