Refactor asset handling: Remove 'immutable' field and update asset types

- Removed the 'immutable' field from AssetGroup in OpenAPI, Protobuf, and related Go files.
- Changed asset type from 'Teleport' to 'Intent' in various locations, including validation and repository logic.
- Updated asset input and output structures to reflect the removal of teleport-specific fields.
- Adjusted transaction handling to accommodate the new asset type.
- Cleaned up related tests to ensure consistency with the new asset structure.

Author: aruokhai

api-spec/openapi/swagger/ark/v1/indexer.openapi.json

@@ -779,9 +779,6 @@
           "id": {
             "type": "string"
           },
-          "immutable": {
-            "type": "boolean"
-          },
           "metadata": {
             "type": "array",
             "items": {
@@ -1311,19 +1308,6 @@
               "$ref": "#/components/schemas/IndexerVtxo"
             }
           },
-          "teleportEvents": {
-            "type": "array",
-            "description": "List of teleport events involved in the transaction",
-            "items": {
-              "$ref": "#/components/schemas/TeleportEvent"
-            }
-          },
-          "teleportHashes": {
-            "type": "array",
-            "items": {
-              "type": "string"
-            }
-          },
           "tx": {
             "type": "string"
           },

api-spec/protobuf/ark/v1/indexer.proto

@@ -238,7 +238,6 @@ message GetAssetGroupResponse {
 message AssetGroup {
   string id = 1;
   uint64 quantity = 2;
-  bool immutable = 3;
   repeated AssetMetadata metadata = 4;
 }
 
@@ -394,7 +393,4 @@ message IndexerSubscriptionEvent {
   string tx = 5;
   map<string, IndexerTxData> checkpoint_txs = 6;
   repeated IndexerVtxo swept_vtxos = 7;
-  // List of teleport events involved in the transaction
-  repeated TeleportEvent teleport_events = 8;
-  repeated string teleport_hashes = 9;
 }

api-spec/protobuf/gen/ark/v1/indexer.pb.go

@@ -336,13 +336,13 @@ func (m *assetGroupValidationMachine) validateOutputs(s *service) error {
 
 func (m *assetGroupValidationMachine) validateInput(s *service, input extension.AssetInput) error {
 	grpAsset := m.group()
-	if input.Type == extension.AssetTypeTeleport {
+	if input.Type == extension.AssetTypeIntent {
 		if grpAsset.AssetId == nil {
 			return errors.TELEPORT_VALIDATION_FAILED.New("asset ID is required for teleport input validation").
 				WithMetadata(errors.TeleportValidationMetadata{})
 		}
 
-		txHash, err := chainhash.NewHash(input.Witness.Txid[:])
+		txHash, err := chainhash.NewHash(input.Txid[:])
 		if err != nil {
 			return errors.TELEPORT_VALIDATION_FAILED.New("invalid intent ID for teleport input validation: %w", err).
 				WithMetadata(errors.TeleportValidationMetadata{})
@@ -360,7 +360,7 @@ func (m *assetGroupValidationMachine) validateInput(s *service, input extension.
 				WithMetadata(errors.TeleportValidationMetadata{})
 		}
 
-		if err := s.validateTeleportInput(*decodedProof, *grpAsset.AssetId, input.Witness.Vout); err != nil {
+		if err := s.validateIntentInput(*decodedProof, *grpAsset.AssetId, input.Vin); err != nil {
 			return err
 		}
 
@@ -464,7 +464,7 @@ func (m *assetOutputValidationMachine) run(s *service) error {
 	}
 }
 
-func (s *service) validateTeleportInput(
+func (s *service) validateIntentInput(
 	intentProof psbt.Packet,
 	assetId extension.AssetId,
 	vout uint32,
@@ -484,7 +484,7 @@ func (s *service) validateTeleportInput(
 	teleportOutputFound := false
 	for _, assetGroup := range assetPacket.Assets {
 		for _, assetOutput := range assetGroup.Outputs {
-			if assetOutput.Type == extension.AssetTypeTeleport && assetId == *assetGroup.AssetId &&
+			if assetOutput.Type == extension.AssetTypeIntent && assetId == *assetGroup.AssetId &&
 				vout == assetOutput.Vout {
 				teleportOutputFound = true
 				break

api-spec/protobuf/gen/ark/v1/indexer.pb.rgw.go

@@ -278,15 +278,12 @@ func NewService(
 			spentVtxos := svc.getSpentVtxos(round.Intents)
 			newVtxos := getNewVtxosFromRound(round)
 
-			newTeleportAssets := getTeleportAssets(round)
-
 			// commitment tx event
 			txEvent := TransactionEvent{
 				TxData:         TxData{Tx: round.CommitmentTx, Txid: round.CommitmentTxid},
 				Type:           CommitmentTxType,
 				SpentVtxos:     spentVtxos,
 				SpendableVtxos: newVtxos,
-				TeleportAssets: newTeleportAssets,
 			}
 
 			svc.propagateTransactionEvent(txEvent)
@@ -1674,12 +1671,10 @@ func (s *service) RegisterIntent(
 							AssetId: grp.AssetId,
 
 							Inputs: []extension.AssetInput{{
-								Type:   extension.AssetTypeTeleport,
+								Type:   extension.AssetTypeIntent,
 								Amount: out.Amount,
-								Witness: extension.TeleportWitness{
-									Txid: proof.UnsignedTx.TxHash(),
-									Vout: out.Vout,
-								},
+								Txid:   proof.UnsignedTx.TxHash(),
+								Vin:    out.Vout,
 							}},
 
 							Outputs: []extension.AssetOutput{{
@@ -4368,7 +4363,6 @@ func (s *service) storeAssetGroups(
 			err := s.repoManager.Assets().InsertAssetGroup(ctx, domain.AssetGroup{
 				ID:             assetId.ToString(),
 				Quantity:       totalOut,
-				Immutable:      asstGp.Immutable,
 				Metadata:       metadataList,
 				ControlAssetID: controlAsset,
 			})
@@ -4382,7 +4376,7 @@ func (s *service) storeAssetGroups(
 			)
 
 			for _, out := range asstGp.Outputs {
-				if out.Type == extension.AssetTypeTeleport {
+				if out.Type == extension.AssetTypeIntent {
 					continue
 				}
 
@@ -4408,35 +4402,6 @@ func (s *service) storeAssetGroups(
 			return fmt.Errorf("asset with id %s not found for update", assetId.ToString())
 		}
 
-		if !assetGp.Immutable && len(metadataList) > 0 {
-			if len(assetGp.ControlAssetID) == 0 {
-				return fmt.Errorf("cannot update mutable asset without control asset")
-			}
-
-			controlAssetID, err := extension.AssetIdFromString(assetGp.ControlAssetID)
-			if err != nil {
-				return fmt.Errorf("error parsing control asset id: %s", err)
-			}
-
-			if controlAssetID == nil {
-				return fmt.Errorf("invalid control asset id for asset %s", assetId.ToString())
-			}
-
-			if err := s.ensureAssetPresence(ctx, assetGroupList, *controlAssetID); err != nil {
-				return fmt.Errorf(
-					"cannot update asset metadata while control asset is being issued",
-				)
-			}
-
-			if err := s.repoManager.Assets().UpdateAssetMetadataList(ctx, assetId.ToString(), metadataList); err != nil {
-				return fmt.Errorf("error updating asset metadata: %s", err)
-			}
-		}
-
-		log.Infof("updated asset metadata for asset id %s",
-			assetId.ToString(),
-		)
-
 		if err := s.updateAssetQuantity(ctx, assetId.ToString(), totalIn, totalOut); err != nil {
 			return err
 		}
@@ -4512,7 +4477,7 @@ func getTeleportAssets(round *domain.Round) []TeleportAsset {
 		events := make([]TeleportAsset, 0)
 		for _, ast := range groups {
 			for outIdx, assetOut := range ast.Outputs {
-				if assetOut.Type != extension.AssetTypeTeleport {
+				if assetOut.Type != extension.AssetTypeIntent {
 					continue
 				}
 

internal/core/application/asset_validation.go

@@ -121,7 +121,6 @@ type TransactionEvent struct {
 	SpendableVtxos []domain.Vtxo
 	SweptVtxos     []domain.Outpoint
 	CheckpointTxs  map[string]TxData
-	TeleportAssets []TeleportAsset
 }
 
 type TeleportAsset struct {