fix: stop bot-UA guard from silently blocking real customers in checkout

Bot UA detection (python-requests, curl) was forcing test mode in
/v1/keys/setup and /v1/keys/trial endpoints. Real SDK users calling
the API would get Stripe test sessions and could never pay.
Rate-limiting already protects against abuse.

- Remove bot-UA → test-mode forcing from both checkout endpoints
- Remove redundant _classify_visitor guard (covered by IP check)
- Keep bot classification for analytics/funnel attribution
- Update test to verify new behavior

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: desiorac

tests/test_visitor_attribution.py

@@ -192,19 +192,21 @@ def test_setup_internal_ip_forces_test_mode(self, client, monkeypatch):
         assert mock_create.call_args.kwargs["api_key"] == "sk_test_fake"
         assert mock_checkout.call_args.kwargs["metadata"]["stripe_mode"] == "test"
 
-    def test_setup_bot_ua_forces_test_mode(self, client, monkeypatch):
+    def test_setup_bot_ua_keeps_live_mode(self, client, monkeypatch):
+        """Bot-like UAs (python-requests, curl) should NOT be forced to test mode —
+        real SDK users would be silently blocked from paying. Rate-limiting protects against abuse."""
         from unittest.mock import MagicMock, patch
         import trust_layer.app as app_mod
         monkeypatch.setattr(app_mod, "STRIPE_TEST_KEY", "sk_test_fake")
         monkeypatch.setattr(app_mod, "STRIPE_PRO_PRICE_ID_TEST", "price_test_pro")
 
         mock_customer = MagicMock()
-        mock_customer.id = "cus_test_bot"
+        mock_customer.id = "cus_live_sdk"
         mock_list = MagicMock()
         mock_list.data = []
         mock_session = MagicMock()
-        mock_session.url = "https://checkout.stripe.com/pay/cs_test"
-        mock_session.id = "cs_test"
+        mock_session.url = "https://checkout.stripe.com/pay/cs_live"
+        mock_session.id = "cs_live"
 
         with patch("stripe.Customer.list", return_value=mock_list), \
              patch("stripe.Customer.create", return_value=mock_customer) as mock_create, \
@@ -214,5 +216,5 @@ def test_setup_bot_ua_forces_test_mode(self, client, monkeypatch):
             }, headers={"user-agent": "python-requests/2.31.0", "x-real-ip": "8.8.8.8"})
 
         assert r.status_code == 200
-        assert mock_create.call_args.kwargs["api_key"] == "sk_test_fake"
-        assert mock_checkout.call_args.kwargs["metadata"]["stripe_mode"] == "test"
+        assert mock_create.call_args.kwargs["api_key"] != "sk_test_fake"
+        assert mock_checkout.call_args.kwargs["metadata"]["stripe_mode"] == "live"

trust_layer/app.py

@@ -886,11 +886,7 @@ async def setup_key(request: Request):
             logger.warning("keys/setup: email %r looks like test — forcing test mode", email)
             req_mode = "test"
     if req_mode == "live" and user_agent and _BOT_UA_RE.search(user_agent):
-        logger.warning("keys/setup: bot UA %r — forcing test mode", user_agent[:80])
-        req_mode = "test"
-    if req_mode == "live" and not visitor.get("is_external", True):
-        logger.warning("keys/setup: visitor classified non-external (%s) — forcing test mode", visitor.get("reason", "unknown"))
-        req_mode = "test"
+        logger.info("keys/setup: bot-like UA %r — keeping live mode (rate-limit protects)", user_agent[:80])
     lang = body.get("lang", "fr")
     if lang not in ("en", "fr"):
         lang = "fr"
@@ -1207,10 +1203,7 @@ async def create_trial(request: Request):
         if "test" in local_part or "diag" in local_part or "e2e" in local_part or "healthcheck" in local_part or "verify" in local_part or "flow-" in local_part:
             req_mode = "test"
     if req_mode == "live" and user_agent and _BOT_UA_RE.search(user_agent):
-        req_mode = "test"
-    if req_mode == "live" and not visitor.get("is_external", True):
-        logger.warning("keys/free-signup: visitor classified non-external (%s) — forcing test mode", visitor.get("reason", "unknown"))
-        req_mode = "test"
+        logger.info("keys/trial: bot-like UA %r — keeping live mode (rate-limit protects)", user_agent[:80])
 
     lang = body.get("lang", "en")
     if lang not in ("en", "fr"):