Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support to generate 'tunnel source <ip_address>' under Tunnel Interfaces #4880

Open
1 task done
nicholas-rosa opened this issue Jan 14, 2025 · 1 comment
Labels
type: enhancement New feature or request

Comments

@nicholas-rosa
Copy link

Enhancement summary

Add support for configuring a source IP under tunnel interfaces. Currently only source Interface is supported.

Which component of AVD is impacted

eos_cli_config_gen

Use case example

interface Tunnel10
   tunnel source 10.10.10.10

Instead of

interface Tunnel10
   tunnel source interface Et1

My devices on 4.32.3M stay unhappy with the source being an interface.

#show interfaces tunnel 10 config-sanity
Tunnel10 configuration:

Configuration errors:
  Tunnel source or source interface address is not configured or invalid

Describe the solution you would like

New key under Tunnel Interfaces. Something like source_address.

Describe alternatives you have considered

eos_cli does the job but it's a one off and not pretty.

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@nicholas-rosa nicholas-rosa added the type: enhancement New feature or request label Jan 14, 2025
@nicholas-rosa nicholas-rosa changed the title Feature request Title Add support for eos_cli_config_gen to generate 'tunnel source <ip_address>' under Tunnel Interfaces Jan 14, 2025
@gmuloc gmuloc changed the title Add support for eos_cli_config_gen to generate 'tunnel source <ip_address>' under Tunnel Interfaces Feat(eos_cli_config_gen): Add support to generate 'tunnel source <ip_address>' under Tunnel Interfaces Jan 15, 2025
@gmuloc
Copy link
Contributor

gmuloc commented Jan 15, 2025

Hi thanks for opening the issue

1/ indeed we don't support source IP today so it can be added to the eos_cli_config_gen model.

to whomever picks this up - tunnel source interface <foo> and tunnel source <ip> are mutually exclusive it seems so one needs to take precedence over the other in the template and this needs to be documented.

@nicholas-rosa would you want to open a PR and give a stab at this PR? we have just published a new guide to help contributing to eos_cli_config_gen: https://avd.arista.com/devel/docs/contribution/authoring_eos_cli_config_gen.html

2/

My devices on 4.32.3M stay unhappy with the source being an interface.

#show interfaces tunnel 10 config-sanity
Tunnel10 configuration:

Configuration errors:
 Tunnel source or source interface address is not configured or invalid

The message seems to indicate that your source interface (Et1) may not have an IP address or it is invalid - not sure what the rest of your config looks like but you may want to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants