Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Replace String with Rc<str> or other data structure for tracking names in parser and checker #39

Closed
johnchandlerburnham opened this issue May 26, 2021 · 0 comments · Fixed by #58
Assignees

Comments

@johnchandlerburnham
Copy link
Member

Currently we do an egregious amount of cloning of String names, like in Lam/Slf/All/Let binders, Vars and Refs. But the thing about names is that they are immutable, once we parse we should never need to change them. So a datatype like

struct Name(Rc<str>)

might significantly improve performance here. Doesn't have to be exactly Rc<str>, but that's probably a good place to start investigating.

Also relevant to argumentcomputer/yatima#38 since I believe String isn't in sp_std

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants