Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't require installation id in github provider #110

Open
zachaller opened this issue Nov 15, 2024 · 0 comments
Open

feat: Don't require installation id in github provider #110

zachaller opened this issue Nov 15, 2024 · 0 comments

Comments

@zachaller
Copy link
Contributor

zachaller commented Nov 15, 2024

We can get the installation id via code following this: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation#using-an-installation-access-token-to-authenticate-as-an-app-installation

We should validate that this makes sense to do as well. Such as will this cause more API calls are there any downsides to doing this?

Maybe we support both modes where if an installation id is configured in secret we use it if not we programatically get it.

@zachaller zachaller changed the title fix: Don't require installation id in github provider feat: Don't require installation id in github provider Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant