Skip to content

Commit 008932a

Browse files
committed
Disable Trackio trace logging by default
1 parent d1536c2 commit 008932a

4 files changed

Lines changed: 25 additions & 11 deletions

File tree

areal/api/cli_args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2435,7 +2435,7 @@ class TrackioConfig:
24352435
space_id: str | None = None
24362436
"""HF Space ID for remote dashboard deployment (e.g. "user/my-space").
24372437
When set, metrics are also pushed to the specified Hugging Face Space."""
2438-
max_rollout_traces_per_step: int = 32
2438+
max_rollout_traces_per_step: int = 0
24392439
"""Maximum rollout/eval trajectories to log as Trackio traces per step.
24402440
Set to 0 or a negative value to disable trace logging."""
24412441

docs/en/cli_reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,7 @@ See: https://github.com/gradio-app/trackio
844844
| `project` | string \| None | `None` | - |
845845
| `name` | string \| None | `None` | - |
846846
| `space_id` | string \| None | `None` | - |
847-
| `max_rollout_traces_per_step` | integer | `32` | - |
847+
| `max_rollout_traces_per_step` | integer | `0` | - |
848848

849849
(section-wand-b)=
850850

docs/zh/cli_reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ See: https://github.com/gradio-app/trackio
842842
| `project` | string \| None | `None` | - |
843843
| `name` | string \| None | `None` | - |
844844
| `space_id` | string \| None | `None` | - |
845-
| `max_rollout_traces_per_step` | integer | `32` | - |
845+
| `max_rollout_traces_per_step` | integer | `0` | - |
846846

847847
(section-wand-b)=
848848

tests/test_trackio_backend.py

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def test_default_optional_fields_are_none(self):
2525
assert config.project is None
2626
assert config.name is None
2727
assert config.space_id is None
28-
assert config.max_rollout_traces_per_step == 32
28+
assert config.max_rollout_traces_per_step == 0
2929

3030
def test_custom_values(self):
3131
"""TrackioConfig should accept custom values."""
@@ -118,7 +118,9 @@ def test_trackio_init_called_when_enabled(
118118

119119
from areal.utils.stats_logger import StatsLogger
120120

121-
config = _make_test_config(TrackioConfig(mode="online"))
121+
config = _make_test_config(
122+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
123+
)
122124
logger = StatsLogger(config, _make_ft_spec())
123125
mock_trackio.init.assert_called_once()
124126
assert logger._trackio_enabled is True
@@ -152,7 +154,9 @@ def test_trackio_log_called_on_commit(
152154

153155
from areal.utils.stats_logger import StatsLogger
154156

155-
config = _make_test_config(TrackioConfig(mode="online"))
157+
config = _make_test_config(
158+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
159+
)
156160
logger = StatsLogger(config, _make_ft_spec())
157161
mock_trackio.log.reset_mock()
158162

@@ -172,7 +176,9 @@ def test_trackio_finish_called_on_close(
172176

173177
from areal.utils.stats_logger import StatsLogger
174178

175-
config = _make_test_config(TrackioConfig(mode="online"))
179+
config = _make_test_config(
180+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
181+
)
176182
logger = StatsLogger(config, _make_ft_spec())
177183
mock_trackio.finish.reset_mock()
178184

@@ -216,7 +222,9 @@ def test_trackio_trace_logging_from_rollout_tensors(
216222

217223
from areal.utils.stats_logger import StatsLogger
218224

219-
config = _make_test_config(TrackioConfig(mode="online"))
225+
config = _make_test_config(
226+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
227+
)
220228
logger = StatsLogger(config, _make_ft_spec())
221229
mock_trackio.log.reset_mock()
222230

@@ -324,7 +332,9 @@ def test_trackio_trace_logging_skips_none_trajectories(
324332

325333
from areal.utils.stats_logger import StatsLogger
326334

327-
config = _make_test_config(TrackioConfig(mode="online"))
335+
config = _make_test_config(
336+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
337+
)
328338
logger = StatsLogger(config, _make_ft_spec())
329339
mock_trackio.log.reset_mock()
330340

@@ -361,7 +371,9 @@ def test_trackio_trace_logging_reconstructs_multiturn_tool_messages(
361371

362372
from areal.utils.stats_logger import StatsLogger
363373

364-
config = _make_test_config(TrackioConfig(mode="online"))
374+
config = _make_test_config(
375+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
376+
)
365377
logger = StatsLogger(config, _make_ft_spec())
366378
mock_trackio.log.reset_mock()
367379

@@ -401,7 +413,9 @@ def test_trackio_trace_logging_prefers_structured_messages(
401413

402414
from areal.utils.stats_logger import StatsLogger
403415

404-
config = _make_test_config(TrackioConfig(mode="online"))
416+
config = _make_test_config(
417+
TrackioConfig(mode="online", max_rollout_traces_per_step=32)
418+
)
405419
logger = StatsLogger(config, _make_ft_spec())
406420
mock_trackio.log.reset_mock()
407421

0 commit comments

Comments
 (0)