Ethernet - allow return to DHCP after begin with static IP

arduino · Dec 5, 2023 · 402e8ea · 402e8ea
1 parent fcc63d9
commit 402e8ea
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/libraries/Ethernet/src/Ethernet.cpp b/libraries/Ethernet/src/Ethernet.cpp
@@ -8,7 +8,11 @@ int arduino::EthernetClass::begin(uint8_t *mac, unsigned long timeout, unsigned
     _initializerCallback();
     if (eth_if == nullptr) return 0;
   }
+  eth_if->set_dhcp(true);
+  _begin(mac, timeout, responseTimeout);
+}
 
+int arduino::EthernetClass::_begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout) {
   if (mac != nullptr) {
     eth_if->get_emac().set_hwaddr(mac);
   }
@@ -53,7 +57,7 @@ int arduino::EthernetClass::begin(uint8_t *mac, IPAddress ip, IPAddress dns, IPA
   eth_if->set_network(_ip, _netmask, _gateway);
   eth_if->add_dns_server(_dnsServer1, nullptr);
 
-  auto ret = begin(mac, timeout, responseTimeout);
+  auto ret = _begin(mac, timeout, responseTimeout);
   return ret;
 }
 

diff --git a/libraries/Ethernet/src/Ethernet.h b/libraries/Ethernet/src/Ethernet.h
@@ -116,6 +116,8 @@ class EthernetClass : public MbedSocketClass {
   constexpr static int maintain () { return DHCP_CHECK_NONE; }
 
 private:
+  int _begin(uint8_t *mac, unsigned long timeout, unsigned long responseTimeout);
+
   volatile EthernetLinkStatus _currentNetworkStatus = Unknown;
   EthernetInterface net;
   EthernetInterface *eth_if = &net;