Skip to content

Fix MKR Vidor 4000 Serial.dtr#109

Closed
sameer wants to merge 1 commit intoarduino-libraries:masterfrom
sameer:patch-1
Closed

Fix MKR Vidor 4000 Serial.dtr#109
sameer wants to merge 1 commit intoarduino-libraries:masterfrom
sameer:patch-1

Conversation

@sameer
Copy link
Copy Markdown

@sameer sameer commented Mar 19, 2020

This value is incorrect and prevents GPIO0 from being pulled at the right time, so esptool could not detect the board at all.
Now, it works perfectly with the added --no-stub parameter.
See this forum post for further discussion: https://forum.arduino.cc/index.php?topic=596970.0

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Mar 20, 2020
@JAndrassy
Copy link
Copy Markdown
Contributor

JAndrassy commented Mar 20, 2020

again, this is Vigor specific. it would not work with Uno WiFi, MKR1010 and Nano 33 IoT.
the solution must be ifdefed for Vigor

#ifdef ARDUINO_SAMD_MKRVIDOR4000

@sameer
Copy link
Copy Markdown
Author

sameer commented Mar 20, 2020

again, this is Vigor specific. it would not work with Uno WiFi, MKR1010 and Nano 33 IoT.
the solution must be ifdefed for Vigor

#ifdef ARDUINO_SAMD_MKRVIDOR4000

Unless there is something I am missing, the statement is already wrapped in an ifdef, so it is Vidor specific as is.

#ifdef ARDUINO_SAMD_MKRVIDOR4000
-    FPGA.digitalWrite(FPGA_NINA_GPIO0, (Serial.dtr() == 1) ? HIGH : LOW);
+    FPGA.digitalWrite(FPGA_NINA_GPIO0, (Serial.dtr() == 0) ? HIGH : LOW);
#else

@sameer sameer changed the title Fix MKR Vidor 4000 Serial.dts Fix MKR Vidor 4000 Serial.dtr Mar 20, 2020
This value is incorrect and prevents GPIO0 from being pulled at the right time, so esptool could not detect the board at all.
Now, it works perfectly with the added --no-stub parameter.
See this forum post for further discussion: https://forum.arduino.cc/index.php?topic=596970.0
@sameer
Copy link
Copy Markdown
Author

sameer commented Sep 25, 2025

Closing since there's been no interest in merging

@sameer sameer closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants