This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Library revamping #106
Closed
Library revamping #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leonardocavagnis
commented
Aug 22, 2023
leonardocavagnis
commented
- Library structure restyling
- Function and class names refactoring
- Removing unused functions
- Removing mbed core direct calls
- Reworking examples
- Adding documentation
…) and RSx (RS485CommClass)
…ass) and TC (TCTempProbeClass)
|
Looking at the compile-sketches workflow, multiple sketches fail to compile due to a missing library: @leonardocavagnis can you resolve this? :) |
|
@leonardocavagnis If the compilation issues are to be fixed on release 4.0.6 of the core, this PR will be blocked until it is accessible for the @Rocketct do we have any blockers for releasing 4.0.6? |
|
Commit arduino/ArduinoCore-mbed@52caeac in 4.0.6 related to the compilation issues in this PR. |
|
Memory usage change @ e3edfa7
Click for full report table
Click for full report CSV |
|
Arduino mbed core 4.0.6 is officially released (thanks @facchinm ) 🎉 ✅ Compiler checks all passing |
|
Memory usage change @ c0bafb8
Click for full report table
Click for full report CSV |
|
Memory usage change @ d418048
Click for full report table
Click for full report CSV |
|
Memory usage change @ 3157745
Click for full report table
Click for full report CSV |
|
Memory usage change @ 00c8404
Click for full report table
Click for full report CSV |
|
Memory usage change @ 5edf8d8
Click for full report table
Click for full report CSV |
mcmchris
suggested changes
Dec 15, 2023
There was a problem hiding this comment.
I've tested the Temp_Probes_Thermocouple example and it doesn't work with the new Library revamp. It works just fine with the published version of the library.
Error: it samples all three channels and outputs something near -2.0 C on each channel.
Temperature CH0 [°C]: -2.08
Temperature CH1 [°C]: -2.08
Temperature CH2 [°C]: -2.08
In the public library, it measures correctly where my TC is connected with an output for example like:
ch1: 30 C
ch2: nan
ch3: nan
I've tried to fix it playing with the enablement pins and stuff but nothing.
|
Memory usage change @ bbb3fe0
Click for full report table
Click for full report CSV |
|
Close PR due to deprecation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.