v2.5.3

Author: rashtao

ChangeLog.md

@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
 
 ## [Unreleased]
 
+## [2.5.3] - 2021-04-23
+
+- improved performances of `VPackParser.toJson()`
 - added `VPackSlice.getSchemaDescription()` to return a printable schema description of the VPack slice
 
 ## [2.5.2] - 2021-03-23

pom.xml

@@ -4,7 +4,7 @@
 
 	<groupId>com.arangodb</groupId>
 	<artifactId>velocypack</artifactId>
-	<version>2.5.3-SNAPSHOT</version>
+	<version>2.5.3</version>
 	<inceptionYear>2017</inceptionYear>
 	<packaging>jar</packaging>
 

src/main/java/com/arangodb/velocypack/VPackParser.java

@@ -280,19 +280,15 @@ private void parse(
 			} else if (value.isBoolean()) {
 				json.append(value.getAsBoolean());
 			} else if (value.isString()) {
-				json.append("\"");
-				json.append(value.getAsString().replace("\"", "\\\""));
-				json.append("\"");
+				appendJsonString(json, value.getAsString());
 			} else if (value.isDouble()) {
 				json.append(value.getAsDouble());
 			} else if (value.isInt()) {
 				json.append(value.getAsLong());
 			} else if (value.isNumber()) {
 				json.append(value.getAsNumber());
 			} else if (value.isDate()) {
-				json.append("\"");
-				json.append(DateUtil.format(value.getAsDate()).replace("\"", "\\\""));
-				json.append("\"");
+				appendJsonString(json, DateUtil.format(value.getAsDate()));
 			} else if (value.isNull()) {
 				json.append(NULL);
 			} else {
@@ -302,10 +298,7 @@ private void parse(
 	}
 
 	private static void appendField(final String attribute, final StringBuilder json) {
-		json.append("\"");
-		json.append(attribute.replace("\"", "\\\""));
-		json.append("\"");
-		json.append(FIELD);
+		appendJsonString(json, attribute).append(FIELD);
 	}
 
 	private void parseObject(final VPackSlice value, final StringBuilder json, final boolean includeNullValues)
@@ -458,6 +451,13 @@ private void parseValue(final VPackBuilder builder, final String fieldName, fina
 		}
 	}
 
+	private static StringBuilder appendJsonString(final StringBuilder json, final String text) {
+		return json
+				.append("\"")
+				.append(text.replace("\"", "\\\""))
+				.append("\"");
+	}
+
 	public static String toJSONString(final String text) {
 		final StringWriter writer = new StringWriter();
 		try {