Remove unneeded v2 method "CheckStatus" (#499)

Author: nikita-vanyasin

CHANGELOG.md

@@ -1,7 +1,6 @@
 # Change Log
 
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
-- [V2] add Response.CheckStatus
 - Add ErrArangoDatabaseNotFound and IsExternalStorageError helper to v2
 - [V2] Support for Collection Documents removal
 - [V2] Fix: Plain Connection doesn't work with JWT authentication

v2/connection/connection.go

@@ -69,10 +69,6 @@ type Request interface {
 type Response interface {
 	// Code returns an HTTP compatible status code of the response.
 	Code() int
-	// CheckStatus checks if the status of the response equals to one of the given status codes.
-	// If so, nil is returned.
-	// If not, an attempt is made to parse an error response in the body and an error is returned.
-	CheckStatus(validStatusCodes ...int) error
 	// Response returns underlying response object
 	Response() interface{}
 	// Endpoint returns the endpoint that handled the request.

v2/connection/connection_http_response.go

@@ -38,16 +38,6 @@ func (j *httpResponse) Response() interface{} {
 	return j.response
 }
 
-func (j *httpResponse) CheckStatus(validStatusCodes ...int) error {
-	for _, x := range validStatusCodes {
-		if x == j.response.StatusCode {
-			// Found valid status code
-			return nil
-		}
-	}
-	return NewError(j.response.StatusCode, "Unexpected status code")
-}
-
 func (j *httpResponse) Code() int {
 	return j.response.StatusCode
 }

v2/connection/connection_http_response_test.go

@@ -25,7 +25,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func Test_httpResponse_Content(t *testing.T) {
@@ -73,19 +72,3 @@ func Test_httpResponse_Content(t *testing.T) {
 		assert.Equal(t, "", j.Content())
 	})
 }
-
-func Test_httpResponse_CheckStatus(t *testing.T) {
-	j := httpResponse{
-		response: &http.Response{
-			StatusCode: http.StatusOK,
-		},
-	}
-
-	t.Run("code expected", func(t *testing.T) {
-		require.NoError(t, j.CheckStatus(http.StatusOK))
-	})
-
-	t.Run("code not expected", func(t *testing.T) {
-		require.Error(t, j.CheckStatus(http.StatusConflict, http.StatusInternalServerError))
-	})
-}