GT-149 Optional computeOn field in computedValues (#418)

Author: jwierzbo

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
 - Add `hex` property to analyzer's properties
 - Add support for `computedValues`
+- Optional `computeOn` field in `computedValues`
 
 ## [1.3.3](https://github.com/arangodb/go-driver/tree/v1.3.3) (2022-07-27)
 - Fix `lastValue` field type

database_collections.go

@@ -154,7 +154,7 @@ type ComputedValue struct {
 	// An array of strings to define on which write operations the value shall be
 	// computed. The possible values are `"insert"`, `"update"`, and `"replace"`.
 	// The default is `["insert", "update", "replace"]`.
-	ComputeOn []ComputeOn `json:"computeOn"`
+	ComputeOn []ComputeOn `json:"computeOn,omitempty"`
 	// Whether the computed value shall take precedence over a user-provided or existing attribute.
 	Overwrite bool `json:"overwrite"`
 	// Whether to let the write operation fail if the expression produces a warning. The default is false.

test/collection_test.go

@@ -200,6 +200,8 @@ func TestCollection_ComputedValues(t *testing.T) {
 		// Check if the computed value is in the list of computed values
 		require.Len(t, prop.ComputedValues, 1)
 		require.Equal(t, computedValue.Name, prop.ComputedValues[0].Name)
+		require.Len(t, prop.ComputedValues[0].ComputeOn, 1)
+		require.Equal(t, computedValue.ComputeOn[0], prop.ComputedValues[0].ComputeOn[0])
 		require.Equal(t, computedValue.Expression, prop.ComputedValues[0].Expression)
 
 		// Create a document
@@ -222,7 +224,20 @@ func TestCollection_ComputedValues(t *testing.T) {
 		require.True(t, createdAtIsPresent)
 
 		// Verify that the computed value is a valid date
-		tm := time.Unix(int64(createdAtValue.(float64)), 0)
+		var createdAtValueInt64 int64
+
+		switch cav := createdAtValue.(type) {
+		case int64:
+			createdAtValueInt64 = cav
+		case float64:
+			createdAtValueInt64 = int64(cav)
+		case uint64:
+			createdAtValueInt64 = int64(cav)
+		default:
+			t.Fatalf("Unexpected type of createdAt value: %T", createdAtValue)
+		}
+
+		tm := time.Unix(createdAtValueInt64, 0)
 		require.True(t, tm.After(time.Now().Add(-time.Second)))
 	})
 
@@ -263,6 +278,45 @@ func TestCollection_ComputedValues(t *testing.T) {
 
 		require.Len(t, prop.ComputedValues, 1)
 	})
+
+	t.Run("Use default ComputeOn values in ComputedValues", func(t *testing.T) {
+		name := "test_default_computeon_computed_values"
+
+		// Add an attribute with the creation timestamp to new documents
+		computedValue := driver.ComputedValue{
+			Name:       "createdAt",
+			Expression: "RETURN DATE_NOW()",
+			Overwrite:  true,
+		}
+
+		_, err := db.CreateCollection(nil, name, nil)
+		require.NoError(t, err)
+
+		// Collection must exist now
+		col, err := db.Collection(nil, name)
+		require.NoError(t, err)
+
+		prop, err := col.Properties(nil)
+		require.NoError(t, err)
+
+		require.Len(t, prop.ComputedValues, 0)
+
+		err = col.SetProperties(nil, driver.SetCollectionPropertiesOptions{
+			ComputedValues: []driver.ComputedValue{computedValue},
+		})
+		require.NoError(t, err)
+
+		// Check if the computed value is in the list of computed values
+		col, err = db.Collection(nil, name)
+		require.NoError(t, err)
+
+		prop, err = col.Properties(nil)
+		require.NoError(t, err)
+
+		require.Len(t, prop.ComputedValues, 1)
+		// we should get the default value for ComputeOn - ["insert", "update", "replace"]
+		require.Len(t, prop.ComputedValues[0].ComputeOn, 3)
+	})
 }
 
 // TestCreateSatelliteCollection create a satellite collection