Skip to content

Commit 0732d38

Browse files
author
lamai93
committed
Fixed output in agency tests for skip.
1 parent cbc9149 commit 0732d38

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

test/agency_lock_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func TestAgencyLock(t *testing.T) {
3636
ctx := context.Background()
3737
c := createClientFromEnv(t, true)
3838
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
39-
t.Skip("Not a cluster")
39+
t.Skipf("Skip agency test: %s", describe(err))
4040
} else if err != nil {
4141
t.Fatalf("Cluster failed: %s", describe(err))
4242
} else {

test/agency_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func getAgencyEndpoints(ctx context.Context, c driver.Client) ([]string, error)
5959
func getAgencyConnection(ctx context.Context, t testEnv, c driver.Client) (agency.Agency, error) {
6060
if os.Getenv("TEST_CONNECTION") == "vst" {
6161
// These tests assume an HTTP connetion, so we skip under this condition
62-
return nil, driver.ArangoError{HasError: true, Code: 412}
62+
return nil, driver.ArangoError{HasError: true, Code: 412, ErrorMessage: "Using vst is not supported in agency tests"}
6363
}
6464
endpoints, err := getAgencyEndpoints(ctx, c)
6565
if err != nil {
@@ -71,7 +71,7 @@ func getAgencyConnection(ctx context.Context, t testEnv, c driver.Client) (agenc
7171
})
7272
if auth := createAuthenticationFromEnv(t); auth != nil {
7373
// This requires a JWT token, which we not always have in this test, so we skip under this condition
74-
return nil, driver.ArangoError{HasError: true, Code: 412}
74+
return nil, driver.ArangoError{HasError: true, Code: 412, ErrorMessage: "Authentication required but not supported in agency tests"}
7575
}
7676
result, err := agency.NewAgency(conn)
7777
if err != nil {
@@ -114,7 +114,7 @@ func TestAgencyRead(t *testing.T) {
114114
ctx := context.Background()
115115
c := createClientFromEnv(t, true)
116116
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
117-
t.Skip("Not a cluster")
117+
t.Skipf("Skip agency test: %s", describe(err))
118118
} else if err != nil {
119119
t.Fatalf("Cluster failed: %s", describe(err))
120120
} else {
@@ -133,7 +133,7 @@ func TestAgencyWrite(t *testing.T) {
133133
ctx := context.Background()
134134
c := createClientFromEnv(t, true)
135135
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
136-
t.Skip("Not a cluster")
136+
t.Skipf("Skip agency test: %s", describe(err))
137137
} else if err != nil {
138138
t.Fatalf("Cluster failed: %s", describe(err))
139139
} else {
@@ -162,7 +162,7 @@ func TestAgencyWriteIfEmpty(t *testing.T) {
162162
ctx := context.Background()
163163
c := createClientFromEnv(t, true)
164164
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
165-
t.Skip("Not a cluster")
165+
t.Skipf("Skip agency test: %s", describe(err))
166166
} else if err != nil {
167167
t.Fatalf("Cluster failed: %s", describe(err))
168168
} else {
@@ -194,7 +194,7 @@ func TestAgencyWriteIfEqualTo(t *testing.T) {
194194
ctx := context.Background()
195195
c := createClientFromEnv(t, true)
196196
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
197-
t.Skip("Not a cluster")
197+
t.Skipf("Skip agency test: %s", describe(err))
198198
} else if err != nil {
199199
t.Fatalf("Cluster failed: %s", describe(err))
200200
} else {
@@ -235,7 +235,7 @@ func TestAgencyRemove(t *testing.T) {
235235
ctx := context.Background()
236236
c := createClientFromEnv(t, true)
237237
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
238-
t.Skip("Not a cluster")
238+
t.Skipf("Skip agency test: %s", describe(err))
239239
} else if err != nil {
240240
t.Fatalf("Cluster failed: %s", describe(err))
241241
} else {
@@ -261,7 +261,7 @@ func TestAgencyRemoveIfEqualTo(t *testing.T) {
261261
ctx := context.Background()
262262
c := createClientFromEnv(t, true)
263263
if a, err := getAgencyConnection(ctx, t, c); driver.IsPreconditionFailed(err) {
264-
t.Skip("Not a cluster")
264+
t.Skipf("Skip agency test: %s", describe(err))
265265
} else if err != nil {
266266
t.Fatalf("Cluster failed: %s", describe(err))
267267
} else {

0 commit comments

Comments
 (0)