Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose upで開発・テスト環境起動できるようにする #26

Open
yuiseki opened this issue Apr 15, 2020 · 3 comments

Comments

@yuiseki
Copy link
Member

yuiseki commented Apr 15, 2020

No description provided.

@takano32
Copy link
Member

やっぱり落ちた。

Attaching to covid19-surveyor_vscovid-crawler_1
vscovid-crawler_1  | Makefile:2: .env: No such file or directory
vscovid-crawler_1  | sed: can't read .env: No such file or directory
vscovid-crawler_1  | make: *** No rule to make target '.env'.  Stop.
covid19-surveyor_vscovid-crawler_1 exited with code 2

@takano32 takano32 reopened this Apr 17, 2020
This was referenced Apr 18, 2020
@tamakiii
Copy link
Collaborator

特にセットアップ手順に書かれていないですが、.env.sampe をコピーする感じみたいですね

こんな感じでセットアップ手順に含めるとよさそうかなー(IMO)

# README.md
make install # or make install-dev
.PHONY: install install-dev dev

install: \
	.env

install-dev: \
	dev \
	install

dev:
	$(eval ENVIRONMENT := development)

.env:
	touch $@
	echo "slack_token=$(SLACK_TOKEN)" >> $@
	echo "environment=$(ENVIRONMENT)" >> $@

@tamakiii
Copy link
Collaborator

crawler slack-bot あたりが大きいので自分だったらこうしちゃうかも(見通しとメンテナンス時の影響範囲絞る意味で)

  • Makefile プロジェクト全体のセットアップ、よく使われるコマンドのエイリアス
  • crawler.mk cralwer
  • slackbot.mk slackbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants