change grpc-liste-addr flag to grpc, add suport for unix and tcp ontop #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please refer to the new flag design. This PR is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. PR Summary
--grpc-listen-addrflag to--grpcfor improved clarity and usability.unixandtcpprotocols:unix:tracee --grpc unixtcp:tracee --grpc tcp2. How to Test
You can test these changes by compiling
traceeand running it with the new--grpcflag. Examples:Using Unix sockets:
Equivalent to:
Using TCP:
Both options should function correctly and reflect the expected behavior.
3. Additional Comments
This PR closes #4388.