Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bpftool binaries and create a bpftool submodule #76

Open
rafaeldtinoco opened this issue Mar 9, 2023 · 2 comments
Open

remove bpftool binaries and create a bpftool submodule #76

rafaeldtinoco opened this issue Mar 9, 2023 · 2 comments

Comments

@rafaeldtinoco
Copy link
Contributor

Currently we have 2 bpftool binaries in order to generate the tailored BTF files. Instead of having binaries in the repo, now that bpftool has a GitHub repository:

https://github.com/libbpf/bpftool

We can simply have that repository as a submodule and compile bpftool as part of the process of using it.

@brycekahle
Copy link
Collaborator

One downside to this, is that you need a full setup to be able to build bpftool everywhere you want to run btfhub.

@rafaeldtinoco
Copy link
Contributor Author

Done by:

#95
#96

Unfortunately, with the mentioned downside. The bpftool compilation is agnostic to distro (depends on available -dev packages so it can be built).

Maybe I should create a docker container to compile both: bpftool and pahole statically, and then install the result binaries where we're running btfhub. This would give us a way to always have both updated whenever we want (oracle/suse/rhel/debian/ubuntu).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants