-
Notifications
You must be signed in to change notification settings - Fork 197
Update placeholder text for input tags #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit fixes the incorrect/misleading placeholder text for the "Allowed File Extensions" field in the bucket settings page.
ConsoleProject ID: Sites (1)
Tip Cursor pagination performs better than offset pagination when loading further pages. |
WalkthroughA single text placeholder update in the storage bucket settings page component. The InputTags component's placeholder text was changed from "Select or type user labels" to "Select or type file extensions" to better reflect the input's purpose for managing file extensions. No logic modifications, state changes, or functional behavior alterations are present. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes This change consists of a straightforward text label update with no logic, conditional flow, or functional implications. The modification is cosmetic and localized to a single component's template. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)
320-321: Fix typo in security settings description."Ecryption" should be "Encryption".
Apply this diff to fix the typo:
- Enable or disable security services for the bucket including <b>Ecryption</b> + Enable or disable security services for the bucket including <b>Encryption</b>
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)
372-372: Consider improving consistency of labels and identifiers.Minor inconsistencies that could be polished:
- Line 372: "Allowed file extension" (singular) vs line 373/381: "extensions" (plural)
- Line 379:
id="user-labels"doesn't match the purpose (file extensions)- Line 380:
label="Labels"is generic; could be more specific like "File extensions"Apply this diff to improve consistency:
- <svelte:fragment slot="title">Allowed file extension</svelte:fragment> + <svelte:fragment slot="title">Allowed file extensions</svelte:fragment> Allowed file extensions. A maximum of 100 file extensions can be added. Leave blank to allow all file types. <svelte:fragment slot="aside"> <Layout.Stack gap="s"> {#key extensions.length} <InputTags - id="user-labels" - label="Labels" + id="file-extensions" + label="File extensions" placeholder="Select or type file extensions" bind:tags={extensions} />Also applies to: 379-380
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ItzNotABug
PR: appwrite/console#2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/views/indexes/view.svelte:84-84
Timestamp: 2025-10-09T12:22:41.099Z
Learning: In the Appwrite console databases UI, user-facing labels like "Columns" should remain unchanged even when internal terminology changes to "fields". The multi-terminology support refactors internal data models without changing the user-facing text.
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)
381-381: Good fix! Placeholder text now accurately reflects the input purpose.The change correctly addresses the issue by updating the placeholder from "user labels" to "file extensions", which matches what this field actually accepts.

What does this PR do?
This PR fixes #2443. The "Allowed File Extensions" field in the bucket settings page showed the placeholder "Select or type user labels", which is incorrect as the field accepts file extensions, not user labels.
Test Plan
(N/A)
Related PRs and Issues
#2443
Have you read the Contributing Guidelines on issues?
Yes.
Summary by CodeRabbit