Skip to content

Conversation

@bittere
Copy link

@bittere bittere commented Oct 30, 2025

What does this PR do?

This PR fixes #2443. The "Allowed File Extensions" field in the bucket settings page showed the placeholder "Select or type user labels", which is incorrect as the field accepts file extensions, not user labels.

Test Plan

(N/A)

Related PRs and Issues

#2443

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

  • Style
    • Updated placeholder text in the file extensions input field on the storage bucket settings page for improved clarity.

This commit fixes the incorrect/misleading placeholder text for the "Allowed File Extensions" field in the bucket settings page.
@appwrite
Copy link

appwrite bot commented Oct 30, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Failed Failed Authorize Preview URL QR Code

Tip

Cursor pagination performs better than offset pagination when loading further pages.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Walkthrough

A single text placeholder update in the storage bucket settings page component. The InputTags component's placeholder text was changed from "Select or type user labels" to "Select or type file extensions" to better reflect the input's purpose for managing file extensions. No logic modifications, state changes, or functional behavior alterations are present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This change consists of a straightforward text label update with no logic, conditional flow, or functional implications. The modification is cosmetic and localized to a single component's template.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Update placeholder text for input tags" is directly related to the main change in the changeset, which updates the placeholder text for the InputTags component bound to file extensions. The title is concise and clear without vague terms, emojis, or noise. While the title could be more specific about the context (file extensions in bucket settings), it accurately conveys the primary change and is specific enough for someone scanning history to understand the nature of the update.
Linked Issues Check ✅ Passed The PR directly addresses the requirements from linked issue #2443. The placeholder text for the "Allowed File Extensions" field has been updated from "Select or type user labels" to "Select or type file extensions" as requested. The change correctly fixes the typo/incorrect label in the bucket settings UI. No coding-related requirements were missed, and the implementation aligns perfectly with the issue's expected behavior.
Out of Scope Changes Check ✅ Passed The PR contains only in-scope changes directly related to the linked issue #2443. A single file was modified with only one change: updating the placeholder text for the InputTags component. No other logic, state, or error handling changes were introduced, and no public/exported-signature changes were detected. The changeset is focused and minimal, containing only what is necessary to address the issue requirement.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)

320-321: Fix typo in security settings description.

"Ecryption" should be "Encryption".

Apply this diff to fix the typo:

-            Enable or disable security services for the bucket including <b>Ecryption</b>
+            Enable or disable security services for the bucket including <b>Encryption</b>
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)

372-372: Consider improving consistency of labels and identifiers.

Minor inconsistencies that could be polished:

  • Line 372: "Allowed file extension" (singular) vs line 373/381: "extensions" (plural)
  • Line 379: id="user-labels" doesn't match the purpose (file extensions)
  • Line 380: label="Labels" is generic; could be more specific like "File extensions"

Apply this diff to improve consistency:

-            <svelte:fragment slot="title">Allowed file extension</svelte:fragment>
+            <svelte:fragment slot="title">Allowed file extensions</svelte:fragment>
             Allowed file extensions. A maximum of 100 file extensions can be added. Leave blank to allow
             all file types.
             <svelte:fragment slot="aside">
                 <Layout.Stack gap="s">
                     {#key extensions.length}
                         <InputTags
-                            id="user-labels"
-                            label="Labels"
+                            id="file-extensions"
+                            label="File extensions"
                             placeholder="Select or type file extensions"
                             bind:tags={extensions} />

Also applies to: 379-380

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bc5fa2 and cd21903.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ItzNotABug
PR: appwrite/console#2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/views/indexes/view.svelte:84-84
Timestamp: 2025-10-09T12:22:41.099Z
Learning: In the Appwrite console databases UI, user-facing labels like "Columns" should remain unchanged even when internal terminology changes to "fields". The multi-terminology support refactors internal data models without changing the user-facing text.
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte (1)

381-381: Good fix! Placeholder text now accurately reflects the input purpose.

The change correctly addresses the issue by updating the placeholder from "user labels" to "file extensions", which matches what this field actually accepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible typo in Storage > Bucket > Settings page

1 participant